-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Takout zip is unsupported file type #357
Comments
I have tested on a windows 11 machine, with 0.18.1 and 0.18.2 versions. Both are accepting the following command:
|
Thanks for checking. Are you handling localization (hu specifically): takeout-20240701T221729Z-005.zip\Takeout\Google Fotók\Nem mentett dokumentum(24)\metaadatok.json I wonder if that's causing the unsupported file type? |
Glad you talk about localisation... So far, I have noticed:
So the .json file is read to determine its type album, photo, print order, whatever...
This shows the that immich go takes zip files as if their were photos. dir "g:\GoogleTakeout\takeout-*.zip" |
C:\Users\Tamas>dir "g:\GoogleTakeout\takeout-*.zip" Directory of g:\GoogleTakeout 07/03/2024 10:15 PM 53,690,142,444 takeout-20240701T221728Z-004.zip |
So far, the only way I have found to reproduce same message is with this command: immich-go -server=http://immich2283 -key=<key> upload -google-photos -dry-run "C:\Users\dev\test" which is unexpected too |
Could I provide you with any additional info/data? |
I have retested with the latest immich-go release and Windows11 , and this command line works as exprected:
|
Sorry for my late reply. I retested with the new version 0.19.1 and am getting the same results. I'm running it from Win 10 Pro / powershell. |
I debugged the main branch quickly and I think I found the culprit... it seems like zip archive number 2/11 is corrupt, even though it looked like it's a valid 50GB zip.
with err: "zip: not a valid zip file" and exits. Unfortunately, my takeout request has expired, so I can no longer redownload this one. It feels pretty silly having to redownload the whole 563GB once again... |
Thank for your investigation. |
I downloaded another 511GB of takeout and tried to upload again. Once again, I'm getting the same behavior as above, but this time I checked there are no corrupted part (zip) files. here's the output: PS C:\Users\Tamas\Downloads\immich-go> .\immich-go.exe -server=http://192.168.18.111:2283/ -key= upload -create-albums -google-photos "g:\GoogleTakeout\takeout-*" Input analysis:scanned image file : 0 Uploading:uploaded : 0 Check the log file: C:\Users\Tamas\AppData\Local\immich-go\immich-go_2024-07-30_19-04-41.log |
I don't understand how this can happen. |
I realized the old master checkout I used for debugging now does work. I would just need to have proper executable for have faster/better console output. Update: I think this is a bug, because it correctly expands the filenames to all the 11 zip files, but yet treats them as an error. Just having the zip extension makes it work. |
Got it! |
I hope I'm not missing something obvious, but just running the basic command on my standard takeout zip files sees them all as unsupported files:
v0.18.1:
immich-go.exe -server=http://192.168.18.111:2283/ -key=<my key> upload -create-albums -google-photos "g:\GoogleTakeout\takeout-*.zip"
immich-go_2024-07-06_14-53-17.log
The text was updated successfully, but these errors were encountered: