Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement global node naming feature for private and organization networks #467

Merged
merged 10 commits into from
Aug 3, 2024

Conversation

sinamics
Copy link
Owner

@sinamics sinamics commented Aug 3, 2024

This PR introduces a global node naming feature that allows consistent naming across networks.

Key functionality:

  1. For private networks:

    • When a user changes a node's name in one network, it updates across all their private networks.
    • Does not affect networks owned by others or organizations.
  2. For organization networks:

    • When enabled, renaming a node in one organization network updates it across all networks within that organization.
    • Does not affect networks outside the organization.
  3. Node registration behavior:

    • When this feature is enabled, upon registering a new node, the system will search for existing names used for this node and apply the first one found.
    • For private networks, it searches only in the user's own networks.
    • For organizations, it searches within the organization's networks.

This feature can be turned off in user settings or organization settings. It will be disabled by default.

Testing:

  • Verify name propagation in private networks
  • Confirm name propagation within organization networks
  • Test node registration behavior in both private and organization contexts
  • Ensure no unintended name changes occur across different users or organizations

Remaining tasks:

  • Add option in user settings for toggle this feature.
  • Add option in Organization settings for toggle this feature.
  • Translations

Dependent on #468
Resolves #462

@github-actions github-actions bot added the ztnet Main Application label Aug 3, 2024
@sinamics sinamics merged commit 6b06596 into main Aug 3, 2024
3 checks passed
@sinamics sinamics deleted the rename-node-globally branch August 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ztnet Main Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Unique names for peers
1 participant