Set user device cookie maxAge to 1 year #537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User device maxAge was previously set to
session
, as i belived this was the same as never, but session will terminate when browser is closed.Updated device cookie to have maxAge of 1 year.
Cookie expire date is not dynamically updated, so the user device will be invalidated in 1 year. This could be improved by udpate the cookie when user interact with ztnet.
Related #526