Don't send auth when both user and pass are empty #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniomika
commented
Sep 30, 2024
| @@ -24,7 +24,7 @@ services: | |||
| volumes: | |||
| - .:/workspaces:cached | |||
| environment: | |||
| NEXTAUTH_URL: "http://10.0.0.217:3000" # Update this to the URL of your dev environment | |||
| NEXTAUTH_URL: "${NEXTAUTH_URL:-http://10.0.0.217:3000}" | |||
There was a problem hiding this comment.
This change was to ensure dev container development works properly.
sinamics
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't send auth when both user and pass are empty.
When using an SMTP relay (such as Google's SMTP Relay,
PLAINauth is still sent by nodemailer even if the user/pass are empty.This PR changes the logic to only include the fields when one of the fields has data, otherwise it should be undefined.