fea: use int for ttl #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
asein-sinch
reviewed
Jun 12, 2024
asein-sinch
reviewed
Jun 13, 2024
asein-sinch
reviewed
Jun 14, 2024
| return null; | ||
| } | ||
|
|
||
| public override void Write(Utf8JsonWriter writer, int? value, JsonSerializerOptions options) |
There was a problem hiding this comment.
Can you also add a test for this one, in order to cover the case where the TTL is null (the e2e only covers the nominal case)? And maybe check if the value is in the correct range.
There was a problem hiding this comment.
ttl null is checked in tests above as well, WithJson matcher makes a deep equal comparison, so if ttl is present, there will be an error. And any extended validation for other fields then obvious missing id is not supported by sdk
asein-sinch
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.