Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make oAuth client related parameters optional #22

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Make oAuth client related parameters optional #22

merged 8 commits into from
Mar 12, 2024

Conversation

650elx
Copy link
Collaborator

@650elx 650elx commented Mar 5, 2024

@650elx 650elx marked this pull request as ready for review March 7, 2024 09:19
Dovchik
Dovchik reviewed Mar 7, 2024
View reviewed changes
Copy link

@Dovchik Dovchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you try to request product sinch.Sms.Send when those parameters isn't present?
What error user will get?

sinch/core/clients/sinch_client_base.py Outdated
key_secret: str = None,
project_id: str = None,
logger_name: str = None,
logger: str = None,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is logger is really an str?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops; I've copy/pasted too much. Fixed

@650elx
Copy link
Collaborator Author

650elx commented Mar 12, 2024

What happens when you try to request product sinch.Sms.Send when those parameters isn't present?
What error user will get?

sinch.core.exceptions.ValidationException: key_id, key_secret and project_id are required by this API. Those credentials can be obtained from Sinch portal.

@650elx 650elx requested a review from Dovchik March 12, 2024 12:59
@650elx 650elx merged commit 41a7406 into main Mar 12, 2024
4 checks passed
@650elx 650elx deleted the devexp-323-make-client-oauth-params-optional branch August 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dovchik Dovchik Dovchik approved these changes

@krogers0607 krogers0607 Awaiting requested review from krogers0607 krogers0607 is a code owner

@asein-sinch asein-sinch Awaiting requested review from asein-sinch asein-sinch is a code owner

@JPPortier JPPortier Awaiting requested review from JPPortier JPPortier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@650elx @Dovchik