DEVEXP-464: Update Verification API #31
Conversation
650elx
requested review from
Dovchik,
krogers0607,
asein-sinch and
JPPortier
as code owners
| @@ -4,6 +4,42 @@ | |||
| from sinch.domains.verification.models import VerificationIdentity | |||
|
|
|||
|
|
|||
| class ReporPhoneCallVerificationDataTransfromationMixin: | |||
There was a problem hiding this comment.
Check for typos:
- ReporPhoneCallVerificationDataTransfromationMixin
- ReporFlashCallVerificationDataTransfromationMixin
- ReporSMSVerificationDataTransfromationMixin
There was a problem hiding this comment.
indeed; copy/paste typos
fixed
| @@ -156,16 +211,11 @@ def get_by_reference(self, reference) -> GetVerificationStatusByReferenceRespons | |||
| ) | |||
| ) | |||
|
|
|||
| def get_by_id(self, id) -> GetVerificationStatusByIdResponse: | |||
There was a problem hiding this comment.
I'm not sure to understand why this endpoint has been removed (moreover without any deprecation warning as mentioned by @JPPortier), it still exists in the specification: https://gitlab.com/sinch/sinch-projects/enterprise-and-messaging/documentation/developer-experience/oas-documentation/-/blob/master/services/verification-oas/verification.yaml?ref_type=heads#L105
There was a problem hiding this comment.
Oops! I've misunderstood the spec file. The endpoint is back.
Indeed. I'm going to bump the major version on the next release. |
|
Closing due to #36 |
https://tickets.sinch.com/browse/DEVEXP-464