Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade cli-boxes #102

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Downgrade cli-boxes #102

merged 1 commit into from
Aug 4, 2024

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Aug 4, 2024

Fixes #97 (comment)

In short, the upgrade caused issues because the boxen has supported "node 18" and not every one of those users are on "node 18.20" yet.

See reports in:

Since there are no improvements in v4, it's easier to stay on v3 for now.

@fregante
Copy link
Contributor Author

fregante commented Aug 4, 2024

Technically [email protected] has always been ">=18.20, >=20.10". Should I just bump the engines instead? See:


https://nodejs.org/api/esm.html#import-attributes

Screenshot

@fregante
Copy link
Contributor Author

fregante commented Aug 4, 2024

update-notifier included v8.0.0 in a minor release, probably breaking a few systems:

yeoman/update-notifier@ad04288

This sequence would fix the situation:

  1. merge this
  2. release v8.0.1
  3. merge Explicitly define Node 18.20+ support #103
  4. release v9.0.0

@Caesarovich
Copy link
Collaborator

LGTM !

Dealing with engine versions is always a big pain. We'll have to be more careful next time.

Could you trigger a release @sindresorhus ? Thanks

@Caesarovich Caesarovich merged commit 3cf4ea9 into sindresorhus:main Aug 4, 2024
3 checks passed
@Caesarovich
Copy link
Collaborator

Also I propose that we finish the ongoing enhancement PRs (such as #99) before publishing v9. That way it wouldn't be too much for nothing.

@fregante fregante deleted the patch-1 branch August 4, 2024 11:07
@fregante
Copy link
Contributor Author

fregante commented Aug 4, 2024

We'll have to be more careful next time

It's kinda difficult because the CI is set to "node 18" but it points to "the latest node 18". Even if you manually check, the engines downstream isn't guaranteed to be accurate. Node >=18.20 means "node 20 is fine", but it wasn't the case here either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants