Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ESM #67

Merged
merged 5 commits into from
Sep 30, 2021
Merged

Move to ESM #67

merged 5 commits into from
Sep 30, 2021

Conversation

LitoMore
Copy link
Contributor

No description provided.

index.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

You also need to npm install -D typescript to work around a XO bug.

@Caesarovich
Copy link
Collaborator

Caesarovich commented Sep 30, 2021

I don't know if the problem is on my side but I do get a lot of XO errors such as these

index.test-d.ts:2:1 ✖ 2:1 Do not reference the index file directly.. unicorn/import-index ✖ 2:49 Unexpected use of file extension "js" for "./index.js" import/extensions ✖ 2:49 Useless path segments for "./index.js", should be "." import/no-useless-path-segments ✖ 10:15 Unexpected trailing comma. @typescript-eslint/comma-dangle ✖ 17:9 Unexpected trailing comma. @typescript-eslint/comma-dangle

It appears that trailing commas have been added everywhere in the code, most probably you have a code beautifier extension that made those changes without you noticing.

Let me know if the XO errors are only on my side, it's odd the GitHub tests didn't stumble on it.

@sindresorhus
Copy link
Owner

sindresorhus commented Sep 30, 2021

@Caesarovich Looks like you didn't run npm install.

I did clone his fork in a fresh directory and I ran NPM install tho. 🤔 Odd

@sindresorhus sindresorhus merged commit 8747277 into sindresorhus:main Sep 30, 2021
@LitoMore LitoMore deleted the esm branch September 30, 2021 03:28
@LitoMore
Copy link
Contributor Author

LitoMore commented Oct 1, 2021

@Caesarovich Is there any node_modules folder in your upper-level directory?

BTW, why are you replying by editing Sindre's message?

@Caesarovich
Copy link
Collaborator

@LitoMore oh I see that was why. Thanks I'll be more careful next time !

And no I don't really what you mean m, I don't seem to have edited anything 🤔

@LitoMore
Copy link
Contributor Author

LitoMore commented Oct 1, 2021

@Caesarovich This one. At first I thought Sindre said it, until I found out that you modified this content.

image

I would like to suggest using Quote reply.

image

@Caesarovich
Copy link
Collaborator

Oh... My bad, I must have missclicked (I'm on phone most of the time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants