-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ESM #67
Move to ESM #67
Conversation
You also need to |
I don't know if the problem is on my side but I do get a lot of XO errors such as these
It appears that trailing commas have been added everywhere in the code, most probably you have a code beautifier extension that made those changes without you noticing. Let me know if the XO errors are only on my side, it's odd the GitHub tests didn't stumble on it. |
@Caesarovich Looks like you didn't run I did clone his fork in a fresh directory and I ran NPM install tho. 🤔 Odd |
@Caesarovich Is there any BTW, why are you replying by editing Sindre's message? |
@LitoMore oh I see that was why. Thanks I'll be more careful next time ! And no I don't really what you mean m, I don't seem to have edited anything 🤔 |
@Caesarovich This one. At first I thought Sindre said it, until I found out that you modified this content. I would like to suggest using |
Oh... My bad, I must have missclicked (I'm on phone most of the time) |
No description provided.