Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserveConsecutiveUppercase option to preserveCamelCase method #101

Closed
wants to merge 1 commit into from
Closed

Conversation

ambujsahu81
Copy link
Contributor

@ambujsahu81 ambujsahu81 commented Nov 12, 2022

What is the PR for?

For issue #95. It ensure that preserveCamelCase method doesn't ignore preserveConsecutiveUppercase option.
It fixes some failing test cases which contains Consecutive upper case characters.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.

@ambujsahu81 ambujsahu81 changed the title Fix-PreserveCamelCase-For-ConsecutiveUppercaseCharacters Add preserveConsecutiveUppercase option to preserveCamelCase method Nov 18, 2022
@ambujsahu81 ambujsahu81 deleted the patch-1 branch December 13, 2022 03:54
@sindresorhus
Copy link
Owner

sindresorhus commented Dec 13, 2022

Why close? Sorry it's been taking a while. My pull request queue has been very long...

@ambujsahu81
Copy link
Contributor Author

Sorry I thought the solution to problem might be not that good. I will create new pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants