Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Attach files menu item and keyboard shortcut #1014

Merged
merged 4 commits into from
Oct 20, 2019
Merged

Add Attach files menu item and keyboard shortcut #1014

merged 4 commits into from
Oct 20, 2019

Conversation

aude
Copy link
Contributor

@aude aude commented Jul 26, 2019

Ctrl+U seems to be used, could not make it work. Went for Ctrl+T instead.

@aude
Copy link
Contributor Author

aude commented Jul 26, 2019

Earlier discussion on the same subject: #357

source/browser.ts Outdated Show resolved Hide resolved
source/menu.ts Outdated Show resolved Hide resolved
@CvX CvX mentioned this pull request Jul 26, 2019
source/browser.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

@aude Can you fix the merge conflict?

@aude
Copy link
Contributor Author

aude commented Oct 9, 2019

Yep.

Sorry for the delay, these PRs dragged out too long. Will make an effort to be more efficient in the future.

I think everything we've discussed is resolved now.

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@aude
Copy link
Contributor Author

aude commented Oct 19, 2019

Yep, done.

@sindresorhus sindresorhus changed the title Add insert files shortcut Add Attach files menu item and keyboard shortcut Oct 20, 2019
@sindresorhus sindresorhus merged commit 984a298 into sindresorhus:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants