Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema validation crash #1037

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

whitecrownclown
Copy link
Contributor

@sindresorhus Fixes #1031

I could not reproduce #1034, I've checked and all enum values are valid. It might be that the config file was edited/corrupted/had old values before the schema was introduced which would explain an app crash. Should be fixed by a clean install / config reset.

Copy link
Collaborator

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(though setting these deep defaults should ideally be handled by electron-store?)

@CvX CvX changed the title [FIX] Schema validation crash Fix schema validation crash Aug 14, 2019
@CvX CvX merged commit 0937650 into sindresorhus:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Launch Caprine on Windows 10
2 participants