Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select views for new sidebar #2065

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

mquevill
Copy link
Collaborator

I'm not sure if it's safe to assume that (most) people have the new sidebar at this point, or if we should retain past compatibility. This should allow for selecting view through the View menu, if users want to select it that way.

I renamed the actions to reflect what Messenger calls the different views as well.

I am very open to any suggestions about how this should be handled or adjusted as needed.

Fixes #1984.

@dusansimic
Copy link
Collaborator

I'm not sure if it's safe to assume that (most) people have the new sidebar at this point

Really? Why? It's been quite a long time now and we haven't had any reports about it. It's mostly that selectors got broken because of ui changes.

@mquevill
Copy link
Collaborator Author

I'm not sure if it's safe to assume that (most) people have the new sidebar at this point

Really? Why? It's been quite a long time now and we haven't had any reports about it. It's mostly that selectors got broken because of ui changes.

It seems like there have been several generations of what's considered "new". I'm good with removing the checks in selectOtherListViews() if you think that's fine.

@dusansimic
Copy link
Collaborator

It seems like there have been several generations of what's considered "new".

That's correct. I'd just like to deprecate checks like these at some point since it becomes quite rare. This could be safely checked with anonymous telemetry which should be opt in in order to respect users privacy but should be recommended in order to help us maintain Caprine. That's however a topic for another discussion.

I'll merge this now. Thanks for the good work!

@dusansimic dusansimic merged commit 261861d into sindresorhus:main Sep 15, 2023
1 check passed
@mquevill mquevill deleted the ShowPages branch September 21, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most view options aren't working
2 participants