Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added binary variant #64

Merged
merged 2 commits into from
May 2, 2023
Merged

feat: added binary variant #64

merged 2 commits into from
May 2, 2023

Conversation

ad4mx
Copy link
Contributor

@ad4mx ad4mx commented Aug 6, 2022

Hello, I've added a binary variant which flashes random strings of binary.

@ad4mx ad4mx changed the title added binary variant feat: added binary variant Aug 6, 2022
@sindresorhus
Copy link
Owner

It feels a little bit too fast and too repetitive. I would include some more random permutations.

@mainrs
Copy link

mainrs commented Aug 8, 2022

It feels a little bit too fast and too repetitive. I would include some more random permutations.

Maybe suffixing them with the number of bits they use could be a good idea as well. binary6 in this case. It would ensure that additional binary spinners have a common naming scheme.

@sindresorhus
Copy link
Owner

Maybe suffixing them with the number of bits they use could be a good idea as well. binary6 in this case. It would ensure that additional binary spinners have a common naming scheme.

I don't think that's necessary. I don't want to encourage a lot of binary spinners. There are endless permutations.

@sindresorhus
Copy link
Owner

Bump :)

@ad4mx
Copy link
Contributor Author

ad4mx commented Apr 30, 2023

Hi, sorry for the inactivity - I forgot about this. Anyways, I slowed the spinner down and added more permutations to the binary numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants