Update xo to v0.48.0 (#1735)

sindresorhus · Feb 17, 2022 · e6de810 · e6de810
1 parent 40b6f05
commit e6de810
Show file tree

Hide file tree

Showing 34 changed files with 49 additions and 49 deletions.
diff --git a/package.json b/package.json
@@ -87,7 +87,7 @@
 		"outdent": "^0.8.0",
 		"typescript": "^4.5.4",
 		"vue-eslint-parser": "^8.0.1",
-		"xo": "^0.47.0"
+		"xo": "^0.48.0"
 	},
 	"peerDependencies": {
 		"eslint": ">=8.8.0"

diff --git a/rules/better-regex.js b/rules/better-regex.js
@@ -25,7 +25,7 @@ const create = context => {
 	}
 
 	return {
-		'Literal[regex]': node => {
+		'Literal[regex]'(node) {
 			const {raw: original, regex} = node;
 
 			// Regular Expressions with `u` flag are not well handled by `regexp-tree`
@@ -63,7 +63,7 @@ const create = context => {
 				fix: fixer => fixer.replaceText(node, optimized),
 			};
 		},
-		[newRegExp]: node => {
+		[newRegExp](node) {
 			const [patternNode, flagsNode] = node.arguments;
 
 			if (typeof patternNode.value !== 'string') {

diff --git a/rules/catch-error-name.js b/rules/catch-error-name.js
@@ -50,7 +50,7 @@ const create = context => {
 		|| name.endsWith(expectedName.charAt(0).toUpperCase() + expectedName.slice(1));
 
 	return {
-		[selector]: node => {
+		[selector](node) {
 			const originalName = node.name;
 
 			if (

diff --git a/rules/consistent-destructuring.js b/rules/consistent-destructuring.js
@@ -57,7 +57,7 @@ const create = context => {
 	const declarations = new Map();
 
 	return {
-		[declaratorSelector]: node => {
+		[declaratorSelector](node) {
 			// Ignore any complex expressions (e.g. arrays, functions)
 			if (!isSimpleExpression(node.init)) {
 				return;
@@ -69,7 +69,7 @@ const create = context => {
 				objectPattern: node.id,
 			});
 		},
-		[memberSelector]: node => {
+		[memberSelector](node) {
 			const declaration = declarations.get(source.getText(node.object));
 
 			if (!declaration) {

diff --git a/rules/consistent-function-scoping.js b/rules/consistent-function-scoping.js
@@ -159,17 +159,17 @@ const create = context => {
 	const functions = [];
 
 	return {
-		':function': () => {
+		':function'() {
 			functions.push(false);
 		},
-		JSXElement: () => {
+		JSXElement() {
 			// Turn off this rule if we see a JSX element because scope
 			// references does not include JSXElement nodes.
 			if (functions.length > 0) {
 				functions[functions.length - 1] = true;
 			}
 		},
-		':function:exit': node => {
+		':function:exit'(node) {
 			const currentFunctionHasJsx = functions.pop();
 			if (currentFunctionHasJsx) {
 				return;

diff --git a/rules/new-for-builtins.js b/rules/new-for-builtins.js
@@ -17,7 +17,7 @@ const create = context => {
 	const sourceCode = context.getSourceCode();
 
 	return {
-		[callExpressionSelector(builtins.enforceNew)]: node => {
+		[callExpressionSelector(builtins.enforceNew)](node) {
 			const {callee, parent} = node;
 			if (isShadowed(context.getScope(), callee)) {
 				return;
@@ -42,7 +42,7 @@ const create = context => {
 				fix: fixer => switchCallExpressionToNewExpression(node, sourceCode, fixer),
 			};
 		},
-		[newExpressionSelector(builtins.disallowNew)]: node => {
+		[newExpressionSelector(builtins.disallowNew)](node) {
 			const {callee} = node;
 
 			if (isShadowed(context.getScope(), callee)) {

diff --git a/rules/no-array-callback-reference.js b/rules/no-array-callback-reference.js
@@ -157,7 +157,7 @@ function getProblem(context, node, method, options) {
 				name,
 				parameters: suggestionParameters,
 			},
-			fix: fixer => {
+			fix(fixer) {
 				const sourceCode = context.getSourceCode();
 				let nodeText = sourceCode.getText(node);
 				if (isParenthesized(node, sourceCode) || type === 'ConditionalExpression') {

diff --git a/rules/no-hex-escape.js b/rules/no-hex-escape.js
@@ -23,7 +23,7 @@ function checkEscape(context, node, value) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	Literal: node => {
+	Literal(node) {
 		if (node.regex || typeof node.value === 'string') {
 			return checkEscape(context, node, node.raw);
 		}

diff --git a/rules/no-invalid-remove-event-listener.js b/rules/no-invalid-remove-event-listener.js
@@ -23,7 +23,7 @@ const removeEventListenerSelector = [
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	[removeEventListenerSelector]: node => {
+	[removeEventListenerSelector](node) {
 		const listener = node.arguments[1];
 		if (['ArrowFunctionExpression', 'FunctionExpression'].includes(listener.type)) {
 			return {

diff --git a/rules/no-keyword-prefix.js b/rules/no-keyword-prefix.js
@@ -102,7 +102,7 @@ const create = context => {
 	}
 
 	return {
-		Identifier: node => {
+		Identifier(node) {
 			const {name, parent} = node;
 			const keyword = findKeywordPrefix(name, options);
 			const effectiveParent = parent.type === 'MemberExpression' ? parent.parent : parent;

diff --git a/rules/no-nested-ternary.js b/rules/no-nested-ternary.js
@@ -18,7 +18,7 @@ const create = context => {
 		[nestTernarySelector(3)]: node =>
 			// Nesting more than one level not allowed.
 			({node, messageId: MESSAGE_ID_TOO_DEEP}),
-		[nestTernarySelector(2)]: node => {
+		[nestTernarySelector(2)](node) {
 			if (!isParenthesized(node, sourceCode)) {
 				return {
 					node,

diff --git a/rules/no-new-buffer.js b/rules/no-new-buffer.js
@@ -54,7 +54,7 @@ function fix(node, sourceCode, method) {
 const create = context => {
 	const sourceCode = context.getSourceCode();
 	return {
-		[newExpressionSelector('Buffer')]: node => {
+		[newExpressionSelector('Buffer')](node) {
 			const method = inferMethod(node.arguments, context.getScope());
 
 			if (method) {

diff --git a/rules/no-null.js b/rules/no-null.js
@@ -40,7 +40,7 @@ const create = context => {
 	};
 
 	return {
-		[selector]: node => {
+		[selector](node) {
 			const {parent} = node;
 			if (!checkStrictEquality && isStrictEqual(parent)) {
 				return;

diff --git a/rules/no-object-as-default-parameter.js b/rules/no-object-as-default-parameter.js
@@ -15,7 +15,7 @@ const objectParameterSelector = [
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = () => ({
-	[objectParameterSelector]: node => {
+	[objectParameterSelector](node) {
 		const {left, right} = node;
 
 		if (left.type === 'Identifier') {

diff --git a/rules/no-process-exit.js b/rules/no-process-exit.js
@@ -45,20 +45,20 @@ const create = context => {
 
 	return {
 		// Check `worker_threads` require / import
-		[importWorkerThreadsSelector]: () => {
+		[importWorkerThreadsSelector]() {
 			requiredWorkerThreadsModule = true;
 		},
 		// Check `process.on` / `process.once` call
-		[processOnOrOnceCallSelector]: node => {
+		[processOnOrOnceCallSelector](node) {
 			processEventHandler = node;
 		},
 		// Check `process.exit` call
-		[processExitCallSelector]: node => {
+		[processExitCallSelector](node) {
 			if (!processEventHandler) {
 				problemNodes.push(node);
 			}
 		},
-		'CallExpression:exit': node => {
+		'CallExpression:exit'(node) {
 			if (node === processEventHandler) {
 				processEventHandler = undefined;
 			}

diff --git a/rules/no-unsafe-regex.js b/rules/no-unsafe-regex.js
@@ -14,7 +14,7 @@ const newRegExpSelector = [
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = () => ({
-	'Literal[regex]': node => {
+	'Literal[regex]'(node) {
 		// Handle regex literal inside RegExp constructor in the other handler
 		if (
 			node.parent.type === 'NewExpression'
@@ -30,7 +30,7 @@ const create = () => ({
 			};
 		}
 	},
-	[newRegExpSelector]: node => {
+	[newRegExpSelector](node) {
 		const arguments_ = node.arguments;
 		const hasRegExp = arguments_[0].regex;
 

diff --git a/rules/no-useless-undefined.js b/rules/no-useless-undefined.js
@@ -165,7 +165,7 @@ const create = context => {
 					start: firstUndefined.loc.start,
 					end: lastUndefined.loc.end,
 				},
-				fix: fixer => {
+				fix(fixer) {
 					let start = firstUndefined.range[0];
 					let end = lastUndefined.range[1];
 

diff --git a/rules/no-zero-fractions.js b/rules/no-zero-fractions.js
@@ -14,7 +14,7 @@ const messages = {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	Literal: node => {
+	Literal(node) {
 		if (!isNumber(node)) {
 			return;
 		}

diff --git a/rules/number-literal-case.js b/rules/number-literal-case.js
@@ -18,7 +18,7 @@ const fix = raw => {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = () => ({
-	Literal: node => {
+	Literal(node) {
 		const {raw} = node;
 
 		let fixed = raw;

diff --git a/rules/numeric-separators-style.js b/rules/numeric-separators-style.js
@@ -97,7 +97,7 @@ const create = context => {
 	};
 
 	return {
-		Literal: node => {
+		Literal(node) {
 			if (!numeric.isNumeric(node) || numeric.isLegacyOctal(node)) {
 				return;
 			}

diff --git a/rules/prefer-array-flat.js b/rules/prefer-array-flat.js
@@ -102,7 +102,7 @@ const emptyArrayConcat = {
 		}),
 		emptyArraySelector('callee.object'),
 	].join(''),
-	getArrayNode: node => {
+	getArrayNode(node) {
 		const argumentNode = node.arguments[0];
 		return argumentNode.type === 'SpreadElement' ? argumentNode.argument : argumentNode;
 	},
@@ -127,7 +127,7 @@ const arrayPrototypeConcat = {
 		}),
 	].join(''),
 	testFunction: node => node.arguments[1].type !== 'SpreadElement' || node.callee.property.name === 'call',
-	getArrayNode: node => {
+	getArrayNode(node) {
 		const argumentNode = node.arguments[1];
 		return argumentNode.type === 'SpreadElement' ? argumentNode.argument : argumentNode;
 	},

diff --git a/rules/prefer-default-parameters.js b/rules/prefer-default-parameters.js
@@ -190,18 +190,18 @@ const create = context => {
 	};
 
 	return {
-		':function': node => {
+		':function'(node) {
 			functionStack.push(node);
 		},
-		':function:exit': () => {
+		':function:exit'() {
 			functionStack.pop();
 		},
-		[assignmentSelector]: node => {
+		[assignmentSelector](node) {
 			const {left, right} = node.expression;
 
 			return checkExpression(node, left, right, true);
 		},
-		[declarationSelector]: node => {
+		[declarationSelector](node) {
 			const {id, init} = node.declarations[0];
 
 			return checkExpression(node, id, init, false);

diff --git a/rules/prefer-includes.js b/rules/prefer-includes.js
@@ -30,7 +30,7 @@ const getProblem = (context, node, target, argumentsNodes) => {
 	return {
 		node: memberExpressionNode.property,
 		messageId: MESSAGE_ID,
-		fix: fixer => {
+		fix(fixer) {
 			const replacement = `${isNegativeResult(node) ? '!' : ''}${targetSource}.includes(${argumentsSource.join(', ')})`;
 			return fixer.replaceText(node, replacement);
 		},
@@ -44,7 +44,7 @@ const includesOverSomeRule = simpleArraySearchRule({
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	BinaryExpression: node => {
+	BinaryExpression(node) {
 		const {left, right, operator} = node;
 
 		if (!isMethodNamed(left, 'indexOf')) {

diff --git a/rules/prefer-math-trunc.js b/rules/prefer-math-trunc.js
@@ -40,7 +40,7 @@ const create = context => {
 	};
 
 	return {
-		':matches(BinaryExpression, AssignmentExpression)[right.type="Literal"]': node => {
+		':matches(BinaryExpression, AssignmentExpression)[right.type="Literal"]'(node) {
 			const {type, operator, right, left} = node;
 			const isAssignment = type === 'AssignmentExpression';
 			if (

diff --git a/rules/prefer-negative-index.js b/rules/prefer-negative-index.js
@@ -132,7 +132,7 @@ function parse(node) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	'CallExpression[callee.type="MemberExpression"]': node => {
+	'CallExpression[callee.type="MemberExpression"]'(node) {
 		const parsed = parse(node);
 
 		if (!parsed) {

diff --git a/rules/prefer-number-properties.js b/rules/prefer-number-properties.js
@@ -50,7 +50,7 @@ const create = context => {
 	const reported = new WeakSet();
 
 	return {
-		[methodsSelector]: node => {
+		[methodsSelector](node) {
 			if (isShadowed(context.getScope(), node)) {
 				return;
 			}
@@ -84,7 +84,7 @@ const create = context => {
 
 			return problem;
 		},
-		[propertiesSelector]: node => {
+		[propertiesSelector](node) {
 			if (reported.has(node) || isShadowed(context.getScope(), node)) {
 				return;
 			}

diff --git a/rules/prefer-optional-catch-binding.js b/rules/prefer-optional-catch-binding.js
@@ -17,7 +17,7 @@ const selector = [
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	[selector]: node => {
+	[selector](node) {
 		const variables = context.getDeclaredVariables(node.parent);
 
 		if (variables.some(variable => variable.references.length > 0)) {

diff --git a/rules/prefer-reflect-apply.js b/rules/prefer-reflect-apply.js
@@ -66,7 +66,7 @@ const fixFunctionPrototypeCall = (node, sourceCode) => {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	[selector]: node => {
+	[selector](node) {
 		const sourceCode = context.getSourceCode();
 		const fix = fixDirectApplyCall(node, sourceCode) || fixFunctionPrototypeCall(node, sourceCode);
 		if (fix) {

diff --git a/rules/prefer-set-has.js b/rules/prefer-set-has.js
@@ -126,7 +126,7 @@ const isMultipleCall = (identifier, node) => {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
-	[selector]: node => {
+	[selector](node) {
 		const variable = findVariable(context.getScope(), node);
 
 		// This was reported https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1075#issuecomment-768073342

diff --git a/rules/prefer-string-replace-all.js b/rules/prefer-string-replace-all.js
@@ -44,7 +44,7 @@ function removeEscapeCharacters(regexString) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = () => ({
-	[selector]: node => {
+	[selector](node) {
 		const {arguments: arguments_, callee} = node;
 		const [search] = arguments_;
 

diff --git a/rules/prefer-type-error.js b/rules/prefer-type-error.js
@@ -112,7 +112,7 @@ const isTypechecking = node => node.type === 'IfStatement' && isTypecheckingExpr
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = () => ({
-	[selector]: node => {
+	[selector](node) {
 		if (
 			isLone(node)
 			&& node.parent.parent

diff --git a/rules/string-content.js b/rules/string-content.js
@@ -74,7 +74,7 @@ const create = context => {
 	}
 
 	return {
-		'Literal, TemplateElement': node => {
+		'Literal, TemplateElement'(node) {
 			const {type, value, raw} = node;
 
 			let string;