Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-string-starts-ends-with: add suggestions for safely handling non-strings #1277

Merged
merged 26 commits into from
May 18, 2021
Merged

prefer-string-starts-ends-with: add suggestions for safely handling non-strings #1277

merged 26 commits into from
May 18, 2021

Commits on May 14, 2021

  1. feat: add suggestions for prefer-string-starts-ends-with rule

    @bmish
    bmish committed May 14, 2021
    Configuration menu
    Copy the full SHA
    458dfdb View commit details
    Browse the repository at this point in the history

  2. improve parenthesis logic, use generator function

    @bmish
    bmish committed May 14, 2021
    Configuration menu
    Copy the full SHA
    cf560f6 View commit details
    Browse the repository at this point in the history

  3. update suggestion messages

    @bmish
    bmish committed May 14, 2021
    Configuration menu
    Copy the full SHA
    1ce3ff3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into prefer-string-starts-ends-with-suggestions 

    * main:
  Temporarily disable `import/extensions` rule
  Update `xo` to v0.40 (sindresorhus#1257)
  Test: Better `output` assertion (sindresorhus#1259)
  `prefer-negative-index`: Refactor (sindresorhus#1255)
  `prefer-dom-node-remove`: Improve parentheses handling (sindresorhus#1254)
  Update `eslint-plugin-eslint-plugin` to v3.0.3 (sindresorhus#1256)
  32.0.1
  `prefer-set-has`: Remove outdated AST types (sindresorhus#1253)
  `prevent-abbreviations`: Fix shorthand import/export detection (sindresorhus#1252)
  32.0.0
  `no-for-loop`: Ignore known non-array loop variables (sindresorhus#1242)
  Add `no-document-cookie` rule (sindresorhus#1244)
  `prefer-array-find`: Singularize variable name in autofix (sindresorhus#1243)
  Update `@babel/core` (sindresorhus#1241)
  Mention libraries used under the hood in `better-regexp` rule doc (sindresorhus#1240)
  `prefer-switch`: Do not add braces to the default case (sindresorhus#1235)
    @bmish
    bmish committed May 14, 2021
    Configuration menu
    Copy the full SHA
    5e2668b View commit details
    Browse the repository at this point in the history

  5. switch to correct getParenthesizedText

    @bmish
    bmish committed May 14, 2021
    Configuration menu
    Copy the full SHA
    f88404f View commit details
    Browse the repository at this point in the history

  6. handle SequenceExpression with string casting

    @bmish
    bmish committed May 14, 2021
    Configuration menu
    Copy the full SHA
    e9b16d8 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. should-add-parentheses-to-conditional-expression-child

    @bmish
    bmish committed May 15, 2021
    Configuration menu
    Copy the full SHA
    accc866 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @bmish
    bmish committed May 15, 2021
    Configuration menu
    Copy the full SHA
    285ee93 View commit details
    Browse the repository at this point in the history

  3. generate suggestions array

    @bmish
    bmish committed May 15, 2021
    Configuration menu
    Copy the full SHA
    37f7af0 View commit details
    Browse the repository at this point in the history

  4. Refactor

    @fisker
    fisker committed May 15, 2021
    Configuration menu
    Copy the full SHA
    cb5e41d View commit details
    Browse the repository at this point in the history

  5. finish refactor

    @bmish
    bmish committed May 15, 2021
    Configuration menu
    Copy the full SHA
    1bb4725 View commit details
    Browse the repository at this point in the history

  6. fix comment

    @bmish
    bmish committed May 15, 2021
    Configuration menu
    Copy the full SHA
    4c6e14e View commit details
    Browse the repository at this point in the history

  7. fix lint

    @bmish
    bmish committed May 15, 2021
    Configuration menu
    Copy the full SHA
    f29f8b3 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Correct fix logic

    @fisker
    fisker committed May 17, 2021
    Configuration menu
    Copy the full SHA
    52f3d66 View commit details
    Browse the repository at this point in the history

  2. Add broken test

    @fisker
    fisker committed May 17, 2021
    Configuration menu
    Copy the full SHA
    216745a View commit details
    Browse the repository at this point in the history

  3. Fix logic

    @fisker
    fisker committed May 17, 2021
    Configuration menu
    Copy the full SHA
    c1e4502 View commit details
    Browse the repository at this point in the history

  4. More complicated comments test

    @fisker
    fisker committed May 17, 2021
    Configuration menu
    Copy the full SHA
    c593626 View commit details
    Browse the repository at this point in the history

  5. Style

    @fisker
    fisker committed May 17, 2021
    Configuration menu
    Copy the full SHA
    e931884 View commit details
    Browse the repository at this point in the history

  6. Add parens for BinaryExpression too

    @fisker
    fisker committed May 17, 2021
    Configuration menu
    Copy the full SHA
    9d8300e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Merge branch 'main' into prefer-string-starts-ends-with-suggestions

    @bmish
    bmish authored May 18, 2021
    Configuration menu
    Copy the full SHA
    4dcdbaf View commit details
    Browse the repository at this point in the history

  2. fix lint

    @bmish
    bmish committed May 18, 2021
    Configuration menu
    Copy the full SHA
    37ae338 View commit details
    Browse the repository at this point in the history

  3. Remove suggestions for known strings

    @fisker
    fisker committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5f48586 View commit details
    Browse the repository at this point in the history

  4. Rename constants

    @fisker
    fisker committed May 18, 2021
    Configuration menu
    Copy the full SHA
    4c80e5a View commit details
    Browse the repository at this point in the history

  5. Update message

    @fisker
    fisker committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5ae4507 View commit details
    Browse the repository at this point in the history

  6. Move throw to top

    @fisker
    fisker committed May 18, 2021
    Configuration menu
    Copy the full SHA
    c8f72ca View commit details
    Browse the repository at this point in the history

  7. Update docs/rules/prefer-string-starts-ends-with.md 

    Co-authored-by: fisker Cheung <[email protected]>
    @bmish @fisker
    bmish and fisker authored May 18, 2021
    Configuration menu
    Copy the full SHA
    3a3d055 View commit details
    Browse the repository at this point in the history