explicit-length-check: Ignore .length || number
#1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't we just place a simple |
If this is too difficult, I'm happy to just open an issue for that as a future improvement. |
|
Hello, Why is this still in draft? |
|
I haven't got time to finish it. Will get back to this soon. |
fisker
force-pushed
the
explicit-length-check-length-or
branch
from
acfb24d
to
f50a154
Compare
|
Added check, only ignores when |
fisker
changed the title
explicit-length-check: Ignore .length || fooexplicit-length-check: Ignore .length || number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1933
Ideally, we should only ignore when right side is a number, but not sure worth the effort.