Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcard are considered as a ics calendar #446

Closed
mdartic opened this issue Apr 11, 2021 · 3 comments
Closed

vcard are considered as a ics calendar #446

mdartic opened this issue Apr 11, 2021 · 3 comments

Comments

@mdartic
Copy link
Contributor

mdartic commented Apr 11, 2021

Hello,

I try the lib on a .vcf file, that begin with BEGIN:VCARD, and file-type return { "ext": "ics", "mime": "text/calendar" }.

Maybe it's related to the detection of ICS.

Would it be better to detect ics files with BEGIN:VCALENDAR ? That would allow to detect vcf files with BEGIN:VCARD ?

@sindresorhus
Copy link
Owner

Yes, good catch. PR welcome to fix this and also add vCard support if you want.

mdartic added a commit to mdartic/file-type that referenced this issue Apr 15, 2021
mdartic added a commit to mdartic/file-type that referenced this issue Apr 15, 2021
@mdartic
Copy link
Contributor Author

mdartic commented Apr 15, 2021

I create the PR #451
Please check it if you have some time :-)

@sindresorhus
Copy link
Owner

Fixed by #451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants