Fix options in combination with function fileTypeStream()
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
changed the title
NodeFileTypeParser constructor in fileTypeStreamfileTypeStream()
Borewit
force-pushed
the
fix-passing-options-to-detecting-stream
branch
from
27d0dba
to
590e231
Compare
Borewit
force-pushed
the
fix-passing-options-to-detecting-stream
branch
from
590e231
to
5576603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using method
fileTypeStream, any options other then thesampleSizewas ignored.This PR correctly passes the options to the
NodeFileTypeParser