-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple pMapSkip
's
#52
Add support for multiple pMapSkip
's
#52
Conversation
@huntharo Would you be willing to help review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to address the O(n^2)
complexity on the number of pMapSkip
items and fix the existing performance issue with the usage of .splice()
in a loop.
I left an example of how to test the performance and how to change the .unshift()
usage back to .push()
with a loop that does a .pop()
(using the array as a O(1)
stack). The only remaining work would be to implement the super splice
loop that loops through result
only a single time and touches each item only a single time.
Co-authored-by: Sindre Sorhus <[email protected]>
pMapSkips
pMapSkips
pMapSkip
's
Thanks :) |
like this: