Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example for trimNewlines #10

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

tommy-mitchell
Copy link
Contributor

I was skimming the description of this library and missed that trimNewlines only strips leading and trailing newlines, not all newlines. I've updated the example to highlight this for dummies like me 😅

trimNewlines('\n🦄\n🦄\r\n');
//=> '🦄\n🦄'

@tommy-mitchell tommy-mitchell mentioned this pull request Mar 20, 2023
@tommy-mitchell
Copy link
Contributor Author

CI failing due to tsd checking some types in node_modules. Updating (as in #11) fixes this.

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@tommy-mitchell tommy-mitchell mentioned this pull request Mar 20, 2023
@sindresorhus sindresorhus merged commit 3d3c62a into sindresorhus:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants