Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for pgvector's vector data type #1

Draft
wants to merge 4 commits into
base: test-array-object
Choose a base branch
from
Draft

feat: Add support for pgvector's vector data type #1

wants to merge 4 commits into from

Commits on Dec 19, 2023

  1. chore: Fix parameter names in docstrings

    @amotl
    amotl committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    9e2f6db View commit details
    Browse the repository at this point in the history

  2. test: Refactor utility functions verify_data and verify_schema 

    By wrapping them into a container class `AssertionHelper`, it is easy
to parameterize them, and to provide them to the test functions using
a pytest fixture.

This way, they are reusable from database adapter implementations which
derive from PostgreSQL.

The motivation for this is because the metadata column prefix `_sdc`
needs to be adjusted for other database systems, as they reject such
columns, being reserved for system purposes. In the specific case of
CrateDB, it is enough to rename it like `__sdc`. Sad but true.
    @amotl
    amotl committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    86bb083 View commit details
    Browse the repository at this point in the history

  3. feat: Add support for pgvector's vector data type

    @amotl
    amotl committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f007377 View commit details
    Browse the repository at this point in the history

  4. chore: Re-add Python 3.8 compatibility

    @amotl
    amotl committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    fb320f1 View commit details
    Browse the repository at this point in the history