-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include custom objects stream for testing all the scenarios #243
Merged
sgandhi1311
merged 34 commits into
TDL-24434-custom-object-support
from
test-custom-objects
Dec 12, 2023
Merged
include custom objects stream for testing all the scenarios #243
sgandhi1311
merged 34 commits into
TDL-24434-custom-object-support
from
test-custom-objects
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bjects with solid analytical info.
…o/tap-hubspot into test-custom-objects
sgandhi1311
force-pushed
the
TDL-24434-custom-object-support
branch
from
November 22, 2023 12:08
8efb496
to
28ba295
Compare
…o/tap-hubspot into test-custom-objects
…o/tap-hubspot into test-custom-objects
…o/tap-hubspot into test-custom-objects
…o/tap-hubspot into test-custom-objects
…o/tap-hubspot into test-custom-objects
…o/tap-hubspot into test-custom-objects
dsprayberry
approved these changes
Dec 8, 2023
…o/tap-hubspot into test-custom-objects
sgandhi1311
merged commit Dec 12, 2023
0c07ebd
into
TDL-24434-custom-object-support
13 checks passed
sgandhi1311
added a commit
that referenced
this pull request
Dec 12, 2023
* initial commit to add support for custom objects * modify the endpoint for custom records * functionality for the discover mode of custom streams * add custom_objects schema * add sync functionality for custom_object records * create shared folder for the re-use of schema * Log a warning for custom object scopes, handling exceptions. * add doc string to definitions * remove custom_object schema stream, as it just the schema of custom objects with solid analytical info. * modifying naming conventions * include shared folder in the package data * include shared json file names * modified package data in setup.py * update manifest file with the shared folder * include custom objects stream for testing all the scenarios * correct the misspelled * make pylint happy * fix the errors * take the recent startdate, as the custom objects are created 2 days before. * remove `custom_` prefix from the name of custom object stream * remove unused code * Update start dates due to the absence of custom object creation in between. * update test client with pagination logic * fix all fields test for deals stream * update STATE assignment post custom object sync * correct variable name
sgandhi1311
added a commit
that referenced
this pull request
Dec 12, 2023
* initial commit to add support for custom objects * modify the endpoint for custom records * functionality for the discover mode of custom streams * add custom_objects schema * add sync functionality for custom_object records * create shared folder for the re-use of schema * Log a warning for custom object scopes, handling exceptions. * add doc string to definitions * remove custom_object schema stream, as it just the schema of custom objects with solid analytical info. * modifying naming conventions * include shared folder in the package data * include shared json file names * modified package data in setup.py * update manifest file with the shared folder * correct the misspelled * make pylint happy * add unit test for the custom object functionality * handle the chains of .get() calls * before sync get the streams from the catalog instead of the api endpoint * make pylint happy * remove `custom_` prefix from the table name * make pylint happy * Add doc string * disable pylint issue - inconsistent-return-statements * fix unit test case * update the discover mode for custom streams * remove trailing space * modify function name * update STATE assignment post custom object sync * move try catch block to the `gen_request_custom_objects` function * correct variable name * include custom objects stream for testing all the scenarios (#243) * initial commit to add support for custom objects * modify the endpoint for custom records * functionality for the discover mode of custom streams * add custom_objects schema * add sync functionality for custom_object records * create shared folder for the re-use of schema * Log a warning for custom object scopes, handling exceptions. * add doc string to definitions * remove custom_object schema stream, as it just the schema of custom objects with solid analytical info. * modifying naming conventions * include shared folder in the package data * include shared json file names * modified package data in setup.py * update manifest file with the shared folder * include custom objects stream for testing all the scenarios * correct the misspelled * make pylint happy * fix the errors * take the recent startdate, as the custom objects are created 2 days before. * remove `custom_` prefix from the name of custom object stream * remove unused code * Update start dates due to the absence of custom object creation in between. * update test client with pagination logic * fix all fields test for deals stream * update STATE assignment post custom object sync * correct variable name * setup and changelog update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This pull request addresses the recent enhancement in the tap (#242) by updating the existing test cases to align with the latest modifications.
Manual QA steps
Risks
Rollback steps