Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include custom objects stream for testing all the scenarios #243

Merged
merged 34 commits into from
Dec 12, 2023

Conversation

sgandhi1311
Copy link
Member

@sgandhi1311 sgandhi1311 commented Nov 10, 2023

Description of change

This pull request addresses the recent enhancement in the tap (#242) by updating the existing test cases to align with the latest modifications.

Manual QA steps

  • Tested integration test cases locally.

Risks

  • low

Rollback steps

  • revert this branch

@sgandhi1311 sgandhi1311 force-pushed the TDL-24434-custom-object-support branch from 8efb496 to 28ba295 Compare November 22, 2023 12:08
@sgandhi1311 sgandhi1311 merged commit 0c07ebd into TDL-24434-custom-object-support Dec 12, 2023
13 checks passed
sgandhi1311 added a commit that referenced this pull request Dec 12, 2023
* initial commit to add support for custom objects

* modify the endpoint for custom records

* functionality for the discover mode of custom streams

* add custom_objects schema

* add sync functionality for custom_object records

* create shared folder for the re-use of schema

* Log a warning for custom object scopes, handling exceptions.

* add doc string to definitions

* remove custom_object schema stream, as it just the schema of custom objects with solid analytical info.

* modifying naming conventions

* include shared folder in the package data

* include shared json file names

* modified package data in setup.py

* update manifest file with the shared folder

* include custom objects stream for testing all the scenarios

* correct the misspelled

* make pylint happy

* fix the errors

* take the recent startdate, as the custom objects are created 2 days before.

* remove `custom_` prefix from the name of custom object stream

* remove unused code

* Update start dates due to the absence of custom object creation in between.

* update test client with pagination logic

* fix all fields test for deals stream

* update STATE assignment post custom object sync

* correct variable name
sgandhi1311 added a commit that referenced this pull request Dec 12, 2023
* initial commit to add support for custom objects

* modify the endpoint for custom records

* functionality for the discover mode of custom streams

* add custom_objects schema

* add sync functionality for custom_object records

* create shared folder for the re-use of schema

* Log a warning for custom object scopes, handling exceptions.

* add doc string to definitions

* remove custom_object schema stream, as it just the schema of custom objects with solid analytical info.

* modifying naming conventions

* include shared folder in the package data

* include shared json file names

* modified package data in setup.py

* update manifest file with the shared folder

* correct the misspelled

* make pylint happy

* add unit test for the custom object functionality

* handle the chains of .get() calls

* before sync get the streams from the catalog instead of the api endpoint

* make pylint happy

* remove `custom_` prefix from the table name

* make pylint happy

* Add doc string

* disable pylint issue - inconsistent-return-statements

* fix unit test case

* update the discover mode for custom streams

* remove trailing space

* modify function name

* update STATE assignment post custom object sync

* move try catch block to the `gen_request_custom_objects` function

* correct variable name

* include custom objects stream for testing all the scenarios (#243)

* initial commit to add support for custom objects

* modify the endpoint for custom records

* functionality for the discover mode of custom streams

* add custom_objects schema

* add sync functionality for custom_object records

* create shared folder for the re-use of schema

* Log a warning for custom object scopes, handling exceptions.

* add doc string to definitions

* remove custom_object schema stream, as it just the schema of custom objects with solid analytical info.

* modifying naming conventions

* include shared folder in the package data

* include shared json file names

* modified package data in setup.py

* update manifest file with the shared folder

* include custom objects stream for testing all the scenarios

* correct the misspelled

* make pylint happy

* fix the errors

* take the recent startdate, as the custom objects are created 2 days before.

* remove `custom_` prefix from the name of custom object stream

* remove unused code

* Update start dates due to the absence of custom object creation in between.

* update test client with pagination logic

* fix all fields test for deals stream

* update STATE assignment post custom object sync

* correct variable name

* setup and changelog update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants