Tdl 26414 rename custom objects #263
Conversation
|
Can you please pull the latest changes from the master branch? |
| @@ -1422,6 +1426,7 @@ def discover_schemas(): | |||
| LOGGER.info('Loading schema for Custom Object - %s', custom_stream["stream"].tap_stream_id) | |||
| result['streams'].append({'stream': custom_stream["stream"].tap_stream_id, | |||
| 'tap_stream_id': custom_stream["stream"].tap_stream_id, | |||
| "table_name": custom_stream["custom_object_name"], | |||
There was a problem hiding this comment.
Is it necessary to have new key table_name? Because it looks like standard ojects won't be having that key.
There was a problem hiding this comment.
Yes, this stream property value will be reflected on the app and in the extracted records. Whereas table_name will retain the original object name which we need to make API requests.
| self.EXPECTED_PAGE_SIZE: 100, | ||
| self.OBEYS_START_DATE: True | ||
| }, | ||
| "custom_object_contacts": { |
There was a problem hiding this comment.
How about testing the corner case scenario for the stream name like - custom_object_custom_object_contacts?
There was a problem hiding this comment.
We only rename custom objects stream if their original name matches with standard stream names like contacts, campaigns, deals. Therefore, if custom object is named as custom_object_custom_object_contacts then we won't take any action on it.
Description of change
This PR addresses an issue where
custom objectsin HubSpot can have the same names asstandard objects(e.g., contacts, campaigns), leading to extraction failures TDL-26380.The fix involves renaming custom objects that share names with standard objects to a distinct
custom_object_<standard_object_name>. This ensures that custom objects are clearly differentiated from standard objects, preventing conflicts and extraction issues.Manual QA steps
Risks
Rollback steps