Backoff for Protocol error and chunked encoding errors #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeshmukh15
approved these changes
May 31, 2023
somethingmorerelevant
approved these changes
May 31, 2023
zachharris1
approved these changes
May 31, 2023
zachharris1
added a commit
that referenced
this pull request
Jun 14, 2023
This reverts commit 038acbe.
Karthipillai
pushed a commit
to MarletteFunding/singer-tap-zendesk
that referenced
this pull request
Oct 2, 2023
* backoff protocol error and chunked encoding errors * add comments * changelog and version bump * minor to patch * refator http.py for backoffs * use imported connectonerror instead of builtin * add backoff for requests_metrics_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds backoff/retries for
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))requests.exceptions.ChunkedEncodingError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))Manual QA steps
Risks
Rollback steps