Add SLA Policy stream #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://developer.zendesk.com/rest_api/docs/core/sla_policies#sla-policies for more informations
|
Thanks @micaelbergeron. Could you format the schema file with an indentation of 2? Otherwise this looks great. |
|
@KAllan357 oh that was ugly, sorry for that. I've updated the schema file. Thanks! |
|
👍 thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
sla_policiesstream according to https://developer.zendesk.com/rest_api/docs/core/sla_policies#sla-policies.This uses Zenpy SlaPolicy API and should conform to the rest of the streams.
I've tried to make the JSONSchema as narrow as possible.