Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dependencies #104

Merged
merged 8 commits into from
Nov 9, 2021
Merged

Updates dependencies #104

merged 8 commits into from
Nov 9, 2021

Conversation

dsprayberry
Copy link
Contributor

@dsprayberry dsprayberry commented Nov 8, 2021

Description of change

Updates pssutil, aiohttp, and cchardet

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

@dmosorast
Copy link
Contributor

Changed this to be a patch version bump, since my interpretation of SemVer indicates that this doesn't qualify as a major because it does not change the public API, it does not qualify as minor because there was no substantial code change (other than linting suggestions), so it must be patch.

https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

@dsprayberry dsprayberry merged commit 62c2698 into master Nov 9, 2021
@dsprayberry dsprayberry deleted the upgrade-setup-dependencies branch November 9, 2021 21:01
@dmosorast dmosorast mentioned this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants