Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Depend on attrs package >= 22.2 #1050

Merged
merged 1 commit into from
Mar 4, 2023
Merged

[python] Depend on attrs package >= 22.2 #1050

merged 1 commit into from
Mar 4, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Mar 4, 2023

Fixes #1049

@johnkerl johnkerl requested a review from bkmartinjr March 4, 2023 02:38
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +9.99 🎉

Comparison is base (a79c9da) 81.25% compared to head (652fdeb) 91.24%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   81.25%   91.24%   +9.99%     
==========================================
  Files          78       30      -48     
  Lines        4187     2261    -1926     
==========================================
- Hits         3402     2063    -1339     
+ Misses        785      198     -587     
Flag Coverage Δ
python 91.24% <ø> (ø)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/include/span/span.hpp
inst/tiledb/include/tiledb/stats.h
R/SOMAExperiment.R
R/TileDBURI.R
R/SOMACollectionBase.R
inst/tiledb/include/tiledb/vfs.h
R/utils-assertions.R
R/SOMAAxisIndexer.R
src/rutilities.h
R/SOMADataFrame.R
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnkerl johnkerl merged commit fe0cc35 into main Mar 4, 2023
@johnkerl johnkerl deleted the kerl/attrs-22-2 branch March 4, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][python] 1.0.0rc3 uses attrs feature more recent than is indicated in the package dependencies
3 participants