Add type declarations #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
commented
Jan 8, 2021
| "eslint-config-node-important-stuff": "^1.1.0", | ||
| "html-webpack-plugin": "^4.5.0", | ||
| "husky": "^4.3.0", | ||
| "html-webpack-plugin": "^5.0.0-beta.4", |
There was a problem hiding this comment.
Necessary because of jantimon/html-webpack-plugin#1526
frehner
reviewed
Jan 8, 2021
| @@ -42,6 +40,8 @@ exports[`standalone-single-spa-webpack-plugin basic-parcel 1`] = ` | |||
| singleSpa.mountRootParcel(parcelConfig, { domElement: parcelContainer, name: 'basic-parcel' }); | |||
| }); | |||
| </script> | |||
| </head> | |||
| <body> | |||
There was a problem hiding this comment.
this snapshot changes seem... unrelated?
There was a problem hiding this comment.
they were related to updating the devDependency for html-webpack-plugin. APparently v5 has some breaking changes. Since it's just a dev dependency though it doesn't force the change on any users.
frehner
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for single-spa-angular to use this, it needs type declarations. We already had the types documented in jsdocs, but weren't publishing them properly for them to be picked up by typescript. This fixes that.