-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-built v6.1.3 uses old version of nise #1861
Comments
We need a better build process to ensure that this situation doesn't happen again. @fatso83 do you have any ideas for this? |
Maybe |
Add warnings about outdated dependencies when building for release manually, to avoid sinonjs#1861.
I created a PR for one possible approach, but I'd be for updating the packages in the script as well. There might be a small risk that, since the build script doesn't run tests, updating the packages as part of the build could accidentally break something. |
In the meantime, would it be possible to publish a minor release with the updated packages? |
Add warnings about outdated dependencies when building for release manually, to avoid #1861.
I used the updated @tzrh can you verify that this works for you? |
It looks good on my end. Thanks! |
Thank you 👍 |
Add warnings about outdated dependencies when building for release manually, to avoid sinonjs#1861.
Describe the bug
As in #1656, the pre-built version of sinon doesn't seem to include the correct version of nise.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
http://sinonjs.org/releases/sinon-6.1.3.js should be built with the latest version of nise.
Context (please complete the following information):
The text was updated successfully, but these errors were encountered: