Update from Bitcoin Core #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🤦♂️ Sorry i didn't even try to build the compiler.. The error was because the node constructor now needs a reference to the context. But it should certainly not perform the duplicate key check on all nodes it tries to build. |
darosior
force-pushed
the
update_from_bitcoin_core
branch
from
bb5fb72
to
930e2f2
Compare
|
Updated the compiler to always create nodes using Both |
|
ACK 930e2f2. Matches the Bitcoin Core master branch code, and compiles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRs introducing Miniscript to Bitcoin Core contained the most up to date version of the code (bitcoin/bitcoin#24148 and bitcoin/bitcoin#24149).
Now they are both merged, update the code here to reflect the updates made in these PRs.