-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metallb load balancer. #486
Open
cryslith
wants to merge
10
commits into
sipb:master
Choose a base branch
from
cryslith:metallb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds and packages the MetalLB load balancer.
Add a new external-ranges key to the setup.yaml config from which external services will be assigned IP addresses.
celskeggs
reviewed
Apr 17, 2020
Very nice work! |
celskeggs
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the metallb load balancer in layer 2 mode. Note that this doesn't provide any sort of high-availability. There's also no changes to
spire virt
, so to use it with that, the external IP ranges need to be from the same subnet that spire configures on the host interface (i.e.cidr-nodes
).Note: I'm deferring more complete testing of this for a different PR; for now we just verify that the metallb components report metrics at all.
Closes #361.
Checklist: