Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metallb load balancer. #486

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add metallb load balancer. #486

wants to merge 10 commits into from

Conversation

cryslith
Copy link
Member

@cryslith cryslith commented Feb 9, 2020

This adds the metallb load balancer in layer 2 mode. Note that this doesn't provide any sort of high-availability. There's also no changes to spire virt, so to use it with that, the external IP ranges need to be from the same subnet that spire configures on the host interface (i.e. cidr-nodes).

Note: I'm deferring more complete testing of this for a different PR; for now we just verify that the metallb components report metrics at all.

Closes #361.


Checklist:

  • I have split up this change into one or more appropriately-delineated commits.
  • The first line of each commit is of the form "[component]: do something"
  • I have written a complete, multi-line commit message for each commit.
  • I have formatted any Go code that I have changed with gofmt.
  • I have written or updated appropriate documentation to cover this change.
  • I have confirmed that this change is covered by at least one appropriate test run by CI.
  • If my change includes new or modified functionality, I have tested that the changes work as expected.
  • I have assigned this issue to an appropriate reviewer. (Choose @celskeggs if you are not otherwise certain.)
  • I consider my PR complete and ready to be merged without my further input, assuming that it passes CI and code review.
  • My changes have passed CI, including an automatic Jenkins deploy.
  • My changes have passed code review.

This builds and packages the MetalLB load balancer.
Add a new external-ranges key to the setup.yaml config from which
external services will be assigned IP addresses.
@cryslith cryslith requested a review from celskeggs April 12, 2020 04:01
@cryslith cryslith removed their assignment Apr 12, 2020
@cryslith cryslith marked this pull request as ready for review April 12, 2020 04:01
platform/upload/BUILD.bazel Outdated Show resolved Hide resolved
platform/spire/src/verify.py Show resolved Hide resolved
@celskeggs
Copy link
Member

Very nice work!

@celskeggs celskeggs added this to the Dev Cluster 7 milestone Apr 18, 2020
@celskeggs celskeggs assigned celskeggs and cryslith and unassigned celskeggs Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up stop-gap load balancer
2 participants