Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-hosting website #503

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Self-hosting website #503

wants to merge 3 commits into from

Conversation

cryslith
Copy link
Member

@cryslith cryslith commented Apr 11, 2020

Create the simplest possible website application, for use in end-to-end testing (in particular, of metallb). I expect the deployment process for this website to become more interesting over time as we modify it to simulate the end-user experience; for now it'll be deployed like our other workloads. I also expect the site itself to become more featureful.

todo: deploy via spire, internal scrape, external scrape?

Depends on #502

See #271


Checklist:

  • I have split up this change into one or more appropriately-delineated commits.
  • The first line of each commit is of the form "[component]: do something"
  • I have written a complete, multi-line commit message for each commit.
  • I have formatted any Go code that I have changed with gofmt.
  • I have written or updated appropriate documentation to cover this change.
  • I have confirmed that this change is covered by at least one appropriate test run by CI.
  • If my change includes new or modified functionality, I have tested that the changes work as expected.
  • I have assigned this issue to an appropriate reviewer. (Choose @celskeggs if you are not otherwise certain.)
  • I consider my PR complete and ready to be merged without my further input, assuming that it passes CI and code review.
  • My changes have passed CI, including an automatic Jenkins deploy.
  • My changes have passed code review.

Create the simplest possible website application,
for use in end-to-end testing.
This checks that the website service is running and
accessible from within the cluster.
It doesn't check that the website is externally accessible.
@cryslith cryslith requested a review from celskeggs April 18, 2020 02:36
@cryslith cryslith marked this pull request as ready for review April 18, 2020 02:37
@celskeggs
Copy link
Member

Nice work!

@celskeggs celskeggs assigned celskeggs and cryslith and unassigned celskeggs Apr 18, 2020
@celskeggs celskeggs added this to the Self-Hosted Website milestone Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants