Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sirupsen/logrus#1434 - Update stretchr/testify to v1.9.0 to resolve 2 High sev vulnerabilities #1435

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcramer-billgo
Copy link

@mcramer-billgo mcramer-billgo commented Jun 7, 2024

Fixes #1434

@mcramer-billgo
Copy link
Author

I'm not sure where the config for the windows AppVeyor runner is to make the version of GO set to 1.18. The updates here appear to require 1.18 as the minimum version. I've updated all the CI yaml files to use 1.18 as a minimum but still erroring in the windows runner.

@dolmen
Copy link
Contributor

dolmen commented Jun 25, 2024

One do not change the minimum go version of a project just to fix a vulnerability in a remote dependency which is not even used in the project.

  • the "vulnerability" is in gopkg.in/yaml.v3 v3.0.0 (fixed in v3.0.1)
  • logrus uses packages github.com/stretchr/testify/assert and github.com/stretchr/testify/require ONLY in its testsuite
  • github.com/stretchr/testify/assert uses gopkg.in/yaml.v3 only for YAMLEq and YAMLEqf which the logrus testsuite doesn't use
  • github.com/stretchr/testify now has a build tag that allows to stop linking with gopkg.in/yaml.v3 See assert: make YAML dependency pluggable via build tags stretchr/testify#1579 (not yet available in a published release, but the build tag can be enabled here right now for a future upgrade).

So this is not at all "2 high severity vulnerabilities". This PR is just FUD and completely useless.

Disclaimer: I'm one Testify co-maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants