Problem: records by themselves are not very useful #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's hard to figure out current issue's state by just lookin at records Solution: introduce a concept of reducers that help building representation based on records.
yrashk
added a commit
that referenced
this pull request
Feb 26, 2018
```
--> sit-web/src/webapp.rs:202:32
|
202 | let record = match sit_core::repository::IssueRecordIter::flatten(issue.record_iter().unwrap()).find(|r| r.encoded_hash() == record) {
| ^^^^^^^ multiple `flatten` found
|
= note: candidate #1 is defined in an impl of the trait `std::iter::Iterator` for the type `sit_core::repository::IssueRecordIter<'_>`
= note: candidate #2 is defined in an impl of the trait `itertools::Itertools` for the type `_`
= note: candidate #3 is defined in the trait `rayon::iter::ParallelIterator`
```
This is, perhaps, related to the addition of the [`iterator_flatten`
nightly feature](rust-lang/rust#48213).
Solution: use itertools' version explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to figure out current issue's state by
just lookin at records
Solution: introduce a concept of reducers that help
building representation based on records.