Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency squizlabs/php_codesniffer to v3.10.3 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 7, 2022

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
squizlabs/php_codesniffer 3.6.1 -> 3.10.3 age adoption passing confidence

Release Notes

PHPCSStandards/PHP_CodeSniffer (squizlabs/php_codesniffer)

v3.10.3

Compare Source

Changed
  • Various housekeeping, including improvements to the tests and documentation.
Fixed
  • Fixed bug #​553 : Squiz.Classes.SelfMemberReference: false negative(s) when namespace operator was encountered between the namespace declaration and the OO declaration.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​579 : AbstractPatternSniff: potential PHP notice during live coding.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​580 : Squiz.Formatting.OperatorBracket: potential PHP notice during live coding.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​581 : PSR12.ControlStructures.ControlStructureSpacing: prevent fixer conflict by correctly handling multiple empty newlines before the first condition in a multi-line control structure.
  • Fixed bug #​585 : Tokenizer not applying tab replacement in heredoc/nowdoc openers.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​588 : Squiz.PHP.EmbeddedPhp false positive when checking spaces after a PHP short open tag.
  • Fixed bug #​597 : Generic.PHP.LowerCaseKeyword did not flag nor fix non-lowercase anonymous class keywords.
    • Thanks to [Marek Štípek][@​maryo] for the patch.
  • Fixed bug #​598 : Squiz.PHP.DisallowMultipleAssignments: false positive on assignments to variable property on object stored in array.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​608 : Squiz.Functions.MultiLineFunctionDeclaration did not take (parameter) attributes into account when checking for one parameter per line.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
Other
  • The provenance of PHAR files associated with a release can now be verified via GitHub Artifact Attestations using the GitHub CLI tool with the following command: gh attestation verify [phpcs|phpcbf].phar -o PHPCSStandards. #​574
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.

v3.10.2

Compare Source

Changed
  • The following sniff(s) have received efficiency improvements:
    • Generic.Functions.FunctionCallArgumentSpacing
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
  • The array format of the information passed to the Reports::generateFileReport() method is now documented in the Reports interface. #​523
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
  • Various housekeeping, including improvements to the tests and documentation.
Fixed
  • Fixed bug #​513 : Generic.Functions.FunctionCallArgumentSpacing did not ignore the body of a match expressions passed as a function argument, which could lead to false positives.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​533 : Generic.WhiteSpace.DisallowTabIndent: tab indentation for heredoc/nowdoc closers will no longer be auto-fixed to prevent parse errors. The issue will still be reported.
    • The error code for heredoc/nowdoc indentation using tabs has been made more specific - TabsUsedHeredocCloser - to allow for selectively excluding the indentation check for heredoc/nowdoc closers.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​534 : Generic.WhiteSpace.DisallowSpaceIndent did not report on space indentation for PHP 7.3 flexible heredoc/nowdoc closers.
    • Closers using space indentation will be reported with a dedicated error code: SpacesUsedHeredocCloser.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​537 : Squiz.PHP.DisallowMultipleAssignments false positive for list assignments at the start of a new PHP block after an embedded PHP statement.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​551 : Squiz.PHP.DisallowMultipleAssignments prevent false positive for function parameters during live coding.
  • Fixed bug #​554 : Generic.CodeAnalysis.UselessOverridingMethod edge case false negative when the call to the parent method would end on a PHP close tag.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​555 : Squiz.Classes.SelfMemberReference edge case false negative when the namespace declaration would end on a PHP close tag.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch

v3.10.1

Compare Source

Added
  • Documentation for the following sniffs:
    • Generic.Commenting.DocComment
    • Thanks to [Rodrigo Primo][@​rodrigoprimo] for the patch.
Changed
  • The following have received efficiency improvements:
    • Type handling in the PHP Tokenizer
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
  • Various housekeeping, including improvements to the tests and documentation.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for their contributions.
Fixed
  • Fixed bug #​110, #​437, #​475: File::findStartOfStatement(): the start of statement/expression determination for tokens in parentheses/short array brackets/others scopes, nested within match expressions, was incorrect in most cases.
    The trickle down effect of the bug fixes made to the File::findStartOfStatement() method, is that the Generic.WhiteSpace.ScopeIndent and the PEAR.WhiteSpace.ScopeIndent sniffs should now be able to correctly determine and fix the indent for match expressions containing nested expressions.
    These fixes also fix an issue with the Squiz.Arrays.ArrayDeclaration sniff and possibly other, unreported bugs.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​504: The tokenizer could inadvertently mistake the last parameter in a function call using named arguments for a DNF type.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​508: Tokenizer/PHP: extra hardening against handling parse errors in the type handling layer.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch

v3.10.0

Compare Source

Added
  • Tokenizer support for PHP 8.2 Disjunctive Normal Form (DNF) types. #​3731, #​387, #​461
    • Includes new T_TYPE_OPEN_PARENTHESIS and T_TYPE_CLOSE_PARENTHESIS tokens to represent the parentheses in DNF types.
    • These new tokens, like other parentheses, will have the parenthesis_opener and parenthesis_closer token array indexes set and the tokens between them will have the nested_parenthesis index.
    • The File::getMethodProperties(), File::getMethodParameters() and File::getMemberProperties() methods now all support DNF types. #​471, #​472, #​473
    • Additionally, the following sniff has been updated to support DNF types:
      • Generic.PHP.LowerCaseType #​478
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patches.
  • Documentation for the following sniffs:
    • Squiz.WhiteSpace.FunctionClosingBraceSpace
    • Thanks to [Przemek Hernik][@​przemekhernik] for the patch.
Changed
  • The help screens have received a face-lift for improved usability and readability. #​447
  • The Squiz.Commenting.ClosingDeclarationComment sniff will now also examine and flag closing comments for traits. #​442
  • The following sniff(s) have efficiency improvements:
    • Generic.Arrays.ArrayIndent
    • Thanks to [Rodrigo Primo][@​rodrigoprimo] for the patch.
  • The autoloader will now always return a boolean value indicating whether it has loaded a class or not. #​479
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
  • Various housekeeping, including improvements to the tests and documentation.
Fixed
  • Fixed bug #​466 : Generic.Functions.CallTimePassByReference was not flagging call-time pass-by-reference in class instantiations using the self/parent/static keywords.
  • Fixed bug #​494 : edge case bug in tokenization of an empty block comment.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​494 : edge case bug in tokenization of an empty single-line DocBlock.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​499 : Generic.ControlStructures.InlineControlStructure now handles statements with a comment between else and if correctly.

v3.9.2

Compare Source

Changed
  • The Generic.ControlStructures.DisallowYodaConditions sniff no longer listens for the null coalesce operator. #​458
  • Various housekeeping, including improvements to the tests and documentation.
Fixed
  • Fixed bug #​381 : Squiz.Commenting.ClosingDeclarationComment could throw the wrong error when the close brace being examined is at the very end of a file.
  • Fixed bug #​385 : Generic.CodeAnalysis.JumbledIncrementer improved handling of parse errors/live coding.
  • Fixed bug #​394 : Generic.Functions.CallTimePassByReference was not flagging call-time pass-by-reference in anonymous class instantiations
  • Fixed bug #​420 : PEAR.Functions.FunctionDeclaration could run into a blocking PHP notice while fixing code containing a parse error.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​421 : File::getMethodProperties() small performance improvement & more defensive coding.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​423 : PEAR.WhiteSpace.ScopeClosingBrace would have a fixer conflict with itself when a close tag was preceded by non-empty inline HTML.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​424 : PSR2.Classes.ClassDeclaration using namespace relative interface names in the extends/implements part of a class declaration would lead to a fixer conflict.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​427 : Squiz.Operators.OperatorSpacing would have a fixer conflict with itself when an operator was preceeded by a new line and the previous line ended in a comment.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​430 : Squiz.ControlStructures.ForLoopDeclaration: fixed potential undefined array index notice
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​431 : PSR2.Classes.ClassDeclaration will no longer try to auto-fix multi-line interface implements statements if these are interlaced with comments on their own line. This prevents a potential fixer conflict.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​453 : Arrow function tokenization was broken when the return type was a stand-alone true or false; or contained true or false as part of a union type.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
Other
  • ESLint 9.0 has been released and changes the supported configuration file format.
    The (deprecated) Generic.Debug.ESLint sniff only supports the "old" configuration file formats and when using the sniff to run ESLint, the ESLINT_USE_FLAT_CONFIG=false environment variable will need to be set when using ESLint >= 9.0.
    For more information, see #​436.

v3.9.1

Compare Source

Added
  • Documentation for the following sniffs:
    • Generic.PHP.RequireStrictTypes
    • Squiz.WhiteSpace.MemberVarSpacing
    • Squiz.WhiteSpace.ScopeClosingBrace
    • Squiz.WhiteSpace.SuperfluousWhitespace
    • Thanks to [Jay McPartland][@​jonmcp] and [Rodrigo Primo][@​rodrigoprimo] for the patches.
Changed
  • The following sniffs have received performance related improvements:
    • Generic.CodeAnalysis.UselessOverridingMethod
    • Generic.Files.ByteOrderMark
    • Thanks to [Rodrigo Primo][@​rodrigoprimo] for the patches.
  • Performance improvement for the "Diff" report. Should be most notable for Windows users. #​355
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
  • The test suite has received some performance improvements. Should be most notable contributors using Windows. #​351
    • External standards with sniff tests using the PHP_CodeSniffer native test framework will also benefit from these changes.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
  • Various housekeeping, including improvements to the tests and documentation.
Fixed
  • Fixed bug #​289 : Squiz.WhiteSpace.OperatorSpacing and PSR12.Operators.OperatorSpacing : improved fixer conflict protection by more strenuously avoiding handling operators in declare statements.
  • Fixed bug #​366 : Generic.CodeAnalysis.UselessOverridingMethod : prevent false negative when the declared method name and the called method name do not use the same case.
  • Fixed bug #​368 : Squiz.Arrays.ArrayDeclaration fixer did not handle static closures correctly when moving array items to their own line.
  • Fixed bug #​404 : Test framework : fixed PHP 8.4 deprecation notice.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch

v3.9.0

Compare Source

Added
  • Tokenizer support for PHP 8.3 typed class constants. #​321
    • Additionally, the following sniffs have been updated to support typed class constants:
      • Generic.NamingConventions.UpperCaseConstantName #​332
      • Generic.PHP.LowerCaseConstant #​330
      • Generic.PHP.LowerCaseType #​331
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patches
  • Tokenizer support for PHP 8.3 readonly anonymous classes. #​309
    • Additionally, the following sniffs have been updated to support readonly anonymous classes:
      • PSR12.Classes.ClassInstantiation #​324
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patches
  • New PHP_CodeSniffer\Sniffs\DeprecatedSniff interface to allow for marking a sniff as deprecated. #​281
    • If a ruleset uses deprecated sniffs, deprecation notices will be shown to the end-user before the scan starts.
      When running in -q (quiet) mode, the deprecation notices will be hidden.
    • Deprecated sniffs will still run and using them will have no impact on the exit code for a scan.
    • In ruleset "explain"-mode (-e) an asterix * will show next to deprecated sniffs.
    • Sniff maintainers are advised to read through the PR description for full details on how to use this feature for their own (deprecated) sniffs.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • New Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence sniff. #​197
    • Forbid mixing different binary boolean operators within a single expression without making precedence clear using parentheses
    • Thanks to [Tim Düsterhus][@​TimWolla] for the contribution
  • Squiz.PHP.EmbeddedPhp : the sniff will now also examine the formatting of embedded PHP statements using short open echo tags. #​27
    • Includes a new ShortOpenEchoNoSemicolon errorcode to allow for selectively ignoring missing semicolons in single line embedded PHP snippets within short open echo tags.
    • The other error codes are the same and do not distinguish between what type of open tag was used.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Documentation for the following sniffs:
    • Generic.WhiteSpace.IncrementDecrementSpacing
    • PSR12.ControlStructures.ControlStructureSpacing
    • PSR12.Files.ImportStatement
    • PSR12.Functions.ReturnTypeDeclaration
    • PSR12.Properties.ConstantVisibility
    • Thanks to [Denis Žoljom][@​dingo-d] and [Rodrigo Primo][@​rodrigoprimo] for the patches
Changed
  • The Performance report can now also be used for a phpcbf run. #​308
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Sniff tests which extend the PHPCS native AbstractSniffUnitTest class will now show a (non-build-breaking) warning when test case files contain fixable errors/warnings, but there is no corresponding .fixed file available in the test suite to verify the fixes against. #​336
    • The warning is only displayed on PHPUnit 7.3.0 and higher.
    • The warning will be elevated to a test failure in PHPCS 4.0.
    • Thanks to [Dan Wallis][@​fredden] for the patch
  • The following sniffs have received performance related improvements:
    • Squiz.PHP.EmbeddedPhp
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Various housekeeping, including improvements to the tests and documentation
Deprecated
  • Support for scanning JavaScript and CSS files. See #​2448.
    • This also means that all sniffs which are only aimed at JavaScript or CSS files are now deprecated.
    • The Javascript and CSS Tokenizers, all Javascript and CSS specific sniffs, and support for JS and CSS in select sniffs which support multiple file types, will be removed in version 4.0.0.
  • The abstract PHP_CodeSniffer\Filters\ExactMatch::getBlacklist() and PHP_CodeSniffer\Filters\ExactMatch::getWhitelist() methods are deprecated and will be removed in the 4.0 release. See #​198.
    • In version 4.0, these methods will be replaced with abstract ExactMatch::getDisallowedFiles() and ExactMatch::getAllowedFiles() methods
    • To make Filters extending ExactMatch cross-version compatible with both PHP_CodeSniffer 3.9.0+ as well as 4.0+, implement the new getDisallowedFiles() and getAllowedFiles() methods.
      • When both the getDisallowedFiles() and getAllowedFiles() methods as well as the getBlacklist() and getWhitelist() are available, the new methods will take precedence over the old methods.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • The MySource standard and all sniffs in it. See #​2471.
    • The MySource standard and all sniffs in it will be removed in version 4.0.0.
  • The Zend.Debug.CodeAnalyzer sniff. See #​277.
    • This sniff will be removed in version 4.0.0.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
Fixed
  • Fixed bug #​127 : Squiz.Commenting.FunctionComment : The MissingParamType error code will now be used instead of MissingParamName when a parameter name is provided, but not its type. Additionally, invalid type hint suggestions will no longer be provided in these cases.
  • Fixed bug #​196 : Squiz.PHP.EmbeddedPhp : fixer will no longer leave behind trailing whitespace when moving code to another line.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​196 : Squiz.PHP.EmbeddedPhp : will now determine the needed indent with higher precision in multiple situations.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​196 : Squiz.PHP.EmbeddedPhp : fixer will no longer insert a stray new line when the closer of a multi-line embedded PHP block and the opener of the next multi-line embedded PHP block would be on the same line.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​235 : Generic.CodeAnalysis.ForLoopWithTestFunctionCall : prevent a potential PHP 8.3 deprecation notice during live coding
  • Fixed bug #​288 : Generic.WhiteSpace.IncrementDecrementSpacing : error message for post-in/decrement will now correctly inform about new lines found before the operator.
  • Fixed bug #​296 : Generic.WhiteSpace.ArbitraryParenthesesSpacing : false positive for non-arbitrary parentheses when these follow the scope closer of a switch case.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​307 : PSR2.Classes.ClassDeclaration : space between a modifier keyword and the class keyword was not checked when the space included a new line or comment.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​325 : Squiz.Operators.IncrementDecrementUsage : the sniff was underreporting when there was (no) whitespace and/or comments in unexpected places.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​335 : PSR12.Files.DeclareStatement : bow out in a certain parse error situation to prevent incorrect auto-fixes from being made.
  • Fixed bug #​340 : Squiz.Commenting.ClosingDeclarationComment : no longer adds a stray newline when adding a missing comment.
Other
  • A "Community cc list" has been introduced to ping maintainers of external standards and integrators for input regarding change proposals for PHP_CodeSniffer which may impact them. #​227
    • For anyone who missed the discussion about this and is interested to be on this list, please feel invited to submit a PR to add yourself.
      The list is located in the .github folder.

v3.8.1

Compare Source

Added
  • Documentation has been added for the following sniffs:
    • Generic.CodeAnalysis.EmptyPHPStatement
    • Generic.Formatting.SpaceBeforeCast
    • Generic.PHP.Syntax
    • Generic.WhiteSpace.LanguageConstructSpacing
    • PSR12.Classes.ClosingBrace
    • PSR12.Classes.OpeningBraceSpace
    • PSR12.ControlStructures.BooleanOperatorPlacement
    • PSR12.Files.OpenTag
    • Thanks to [Rodrigo Primo][@​rodrigoprimo] and [Denis Žoljom][@​dingo-d] for the patches
Changed
  • GitHub releases will now always only contain unversioned release assets (PHARS + asc files) (same as it previously was in the squizlabs repo). See #​205 for context.
    • Thanks to [Shivam Mathur][@​shivammathur] for opening a discussion about this
  • Various housekeeping, includes improvements to the tests and documentation
Fixed
  • Fixed bug #​124 : Report Full : avoid unnecessarily wrapping lines when -s is used
  • Fixed bug #​124 : Report Full : fix incorrect bolding of pipes when -s is used and messages wraps
  • Fixed bug #​150 : Squiz.WhiteSpace.KeywordSpacing : prevent a PHP notice when run during live coding
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​154 : Report Full : delimiter line calculation could go wonky on wide screens when a report contains multi-line messages
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​178 : Squiz.Commenting.VariableComment : docblocks were incorrectly being flagged as missing when a property declaration used PHP native union/intersection type declarations
    • Thanks to [Ferdinand Kuhl][@​fcool] for the patch
  • Fixed bug #​211 : Squiz.Commenting.VariableComment : docblocks were incorrectly being flagged as missing when a property declaration used PHP 8.2+ stand-alone true/false/null type declarations
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​211 : Squiz.Commenting.VariableComment : docblocks were incorrectly being flagged as missing when a property declaration used PHP native parent, self or a namespace relative class name type declaration
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug #​226 : Generic.CodeAnalysis.ForLoopShouldBeWhileLoop : prevent a potential PHP 8.3 deprecation notice during live coding

v3.8.0

Compare Source

Squizlabs/PHP_CodeSniffer is dead. Long live PHPCSStandards/PHP_CodeSniffer!

Breaking Changes
  • The squizlabs/PHP_CodeSniffer repository has been abandoned. The PHPCSStandards/PHP_CodeSniffer repository will serve as the continuation of the project. For more information about this change, please read the announcement.
    • Installation of PHP_CodeSniffer via PEAR is no longer supported.
      • Users will need to switch to another installation method.
      • Note: this does not affect the PEAR sniffs.
    • For Composer users, nothing changes.
      • In contrast to earlier information, the squizlabs/php_codesniffer package now points to the new repository and everything will continue to work as before.
    • PHIVE users may need to clear the PHIVE URL cache.
      • PHIVE users who don't use the package alias, but refer to the package URL, will need to update the URL from https://squizlabs.github.io/PHP_CodeSniffer/phars/ to https://phars.phpcodesniffer.com/phars/.
    • Users who download the PHAR files using curl or wget, will need to update the download URL from https://squizlabs.github.io/PHP_CodeSniffer/[phpcs|phpcbf].phar or https://github.com/squizlabs/PHP_CodeSnifffer/releases/latest/download/[phpcs|phpcbf].phar to https://phars.phpcodesniffer.com/[phpcs|phpcbf].phar.
    • For users who install PHP_CodeSniffer via the Setup-PHP action runner for GitHub Actions, nothing changes.
    • Users using a git clone will need to update the clone address from [email protected]:squizlabs/PHP_CodeSniffer.git to [email protected]:PHPCSStandards/PHP_CodeSniffer.git.
      • Contributors will need to fork the new repo and add both the new fork as well as the new repo as remotes to their local git copy of PHP_CodeSniffer.
      • Users who have (valid) open issues or pull requests in the squizlabs/PHP_CodeSniffer repository are invited to resubmit these to the PHPCSStandards/PHP_CodeSniffer repository.
Added
  • Runtime support for PHP 8.3. All known PHP 8.3 deprecation notices have been fixed
    • Syntax support for new PHP 8.3 features will follow in a future release
    • If you find any PHP 8.3 deprecation notices which were missed, please report them
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patches
  • Added support for PHP 8.2 readonly classes to File::getClassProperties() through a new is_readonly array index in the return value
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Added support for PHP 8.2 readonly classes to a number of sniffs
    • Generic.CodeAnalysis.UnnecessaryFinalModifier
    • PEAR.Commenting.ClassComment
    • PEAR.Commenting.FileComment
    • PSR1.Files.SideEffects
    • PSR2.Classes.ClassDeclaration
    • PSR12.Files.FileHeader
    • Squiz.Classes.ClassDeclaration
    • Squiz.Classes.LowercaseClassKeywords
    • Squiz.Commenting.ClassComment
    • Squiz.Commenting.DocCommentAlignment
    • Squiz.Commenting.FileComment
    • Squiz.Commenting.InlineComment
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Added support for PHP 8.2 true as a stand-alone type declaration
    • The File::getMethodProperties(), File::getMethodParameters() and File::getMemberProperties() methods now all support the true type
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Added support for PHP 8.2 true as a stand-alone type to a number of sniffs
    • Generic.PHP.LowerCaseType
    • PSr12.Functions.NullableTypeDeclaration
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Added a Performance report to allow for finding "slow" sniffs
    • To run this report, run PHPCS with --report=Performance.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Generic.PHP.RequireStrictTypes : new warning for when there is a declare statement, but the strict_types directive is set to 0
    • The warning can be turned off by excluding the Generic.PHP.RequireStrictTypes.Disabled error code
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Squiz.Commenting.FunctionComment : new ParamNameUnexpectedAmpersandPrefix error for parameters annotated as passed by reference while the parameter is not passed by reference
  • Documentation has been added for the following sniffs:
    • PSR2.Files.ClosingTag
    • PSR2.Methods.FunctionCallSignature
    • PSR2.Methods.FunctionClosingBrace
    • Thanks to [Atsushi Okui][@​blue32a] for the patch
  • Support for PHPUnit 8 and 9 to the test suite
    • Test suites for external standards which run via the PHPCS native test suite can now run on PHPUnit 4-9 (was 4-7)
    • If any of these tests use the PHPUnit setUp()/tearDown() methods or overload the setUp() in the AbstractSniffUnitTest test case, they will need to be adjusted. See the PR details for further information
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
Changed
  • Changes have been made to the way PHPCS handles invalid sniff properties being set in a custom ruleset
    • Fixes PHP 8.2 deprecation notices for properties set in a (custom) ruleset for complete standards/complete sniff categories
    • Invalid sniff properties set for individual sniffs will now result in an error and halt the execution of PHPCS
      • A descriptive error message is provided to allow users to fix their ruleset
    • Sniff properties set for complete standards/complete sniff categories will now only be set on sniffs which explicitly support the property
      • The property will be silently ignored for those sniffs which do not support the property
    • Invalid sniff properties set for sniffs via inline annotations will result in an informative Internal.PropertyDoesNotExist errror on line 1 of the scanned file, but will not halt the execution of PHPCS
    • For sniff developers, it is strongly recommended for sniffs to explicitly declare any user-adjustable public properties
      • If dynamic properties need to be supported for a sniff, either declare the magic __set()/__get()/__isset()/__unset() methods on the sniff or let the sniff extend stdClass
      • Note: The #[\AllowDynamicProperties] attribute will have no effect for properties which are being set in rulesets
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • The third parameter for the Ruleset::setSniffProperty() method has been changed to expect an array
    • Sniff developers/integrators of PHPCS may need to make some small adjustments to allow for this change
    • Existing code will continue to work but will throw a deprecation error
    • The backwards compatiblity layer will be removed in PHPCS 4.0
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • When using auto report width (the default) a value of 80 columns will be used if the width cannot be determined
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Sniff error messages are now more informative to help bugs get reported to the correct project
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Generic.CodeAnalysis.UnusedFunctionParameter will now ignore magic methods for which the signature is defined by PHP
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Generic.Functions.OpeningFunctionBraceBsdAllman will now check the brace indent before the opening brace for empty functions
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Generic.Functions.OpeningFunctionBraceKernighanRitchie will now check the spacing before the opening brace for empty functions
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Generic.WhiteSpace.IncrementDecrementSpacing now detects more spacing issues
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • PSR2.Classes.PropertyDeclaration now enforces that the readonly modifier comes after the visibility modifier
    • PSR2 and PSR12 do not have documented rules for this as they pre-date the readonly modifier
    • PSR-PER has been used to confirm the order of this keyword so it can be applied to PSR2 and PSR12 correctly
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • PEAR.Commenting.FunctionComment + Squiz.Commenting.FunctionComment: the SpacingAfter error can now be auto-fixed
  • Squiz.PHP.InnerFunctions sniff no longer reports on OO methods for OO structures declared within a function or closure
  • Squiz.PHP.NonExecutableCode will now also flag redundant return statements just before a closure close brace
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Runtime performance improvement for PHPCS CLI users. The improvement should be most noticeable for users on Windows.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • The following sniffs have received performance related improvements:
    • Generic.PHP.LowerCaseConstant
    • Generic.PHP.LowerCaseType
    • PSR12.Files.OpenTag
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patches
  • The -e (explain) command will now list sniffs in natural order
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Tests using the PHPCS native test framework with multiple test case files will now run the test case files in numeric order.
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • The following sniffs have received minor message readability improvements:
    • Generic.Arrays.ArrayIndent
    • Generic.Formatting.SpaceAfterCast
    • Generic.Formatting.SpaceAfterNot
    • Generic.WhiteSpace.SpreadOperatorSpacingAfter
    • Squiz.Arrays.ArrayDeclaration
    • Squiz.Commenting.DocCommentAlignment
    • Squiz.ControlStructures.ControlSignature
    • Thanks to [Danny van der Sluijs][@​DannyvdSluijs] and [Juliette Reinders Folmer][@​jrfnl] for the patches
  • Improved README syntax highlighting
  • Various documentation improvements
Removed
  • Removed support for installation via PEAR
    • Use composer or the PHAR files instead
Fixed
  • Fixed bug [#​2857][sq-2857] : Squiz/NonExecutableCode: prevent false positives when exit is used in a ternary expression or as default with null coalesce
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3386][sq-3386] : PSR1/SideEffects : improved recognition of disable/enable annotations
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3557][sq-3557] : Squiz.Arrays.ArrayDeclaration will now ignore PHP 7.4 array unpacking when determining whether an array is associative
  • Fixed bug [#​3592][sq-3592] : Squiz/NonExecutableCode: prevent false positives when a PHP 8.0+ inline throw expression is encountered
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3715][sq-3715] : Generic/UnusedFunctionParameter: fixed incorrect errorcode for closures/arrow functions nested within extended classes/classes which implement
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3717][sq-3717] : Squiz.Commenting.FunctionComment: fixed false positive for InvalidNoReturn when type is never
    • Thanks to [Choraimy Kroonstuiver][@​axlon] for the patch
  • Fixed bug [#​3720][sq-3720] : Generic/RequireStrictTypes : will now bow out silently in case of parse errors/live coding instead of throwing false positives/false negatives
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3720][sq-3720] : Generic/RequireStrictTypes : did not handle multi-directive declare statements
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3722][sq-3722] : Potential "Uninitialized string offset 1" in octal notation backfill
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3736][sq-3736] : PEAR/FunctionDeclaration: prevent fixer removing the close brace (and creating a parse error) when there is no space between the open brace and close brace of a function
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3739][sq-3739] : PEAR/FunctionDeclaration: prevent fixer conflict, and potentially creating a parse error, for unconventionally formatted return types
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3770][sq-3770] : Squiz/NonExecutableCode: prevent false positives for switching between PHP and HTML
  • Fixed bug [#​3773][sq-3773] : Tokenizer/PHP: tokenization of the readonly keyword when used in combination with PHP 8.2 disjunctive normal types
  • Fixed bug [#​3776][sq-3776] : Generic/JSHint: error when JSHint is not available
  • Fixed bug [#​3777][sq-3777] : Squiz/NonExecutableCode: slew of bug fixes, mostly related to modern PHP
    • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
  • Fixed bug [#​3778][sq-3778] : Squiz/LowercasePHPFunctions: bug fix for class names in attributes
    • Thanks to [Juliette Reinders Fol

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@coveralls
Copy link

coveralls commented Mar 7, 2022

Pull Request Test Coverage Report for Build 3509473569

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.162%

Totals Coverage Status
Change from base Build 1329398207: 0.0%
Covered Lines: 92
Relevant Lines: 148

💛 - Coveralls

@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from 2ef3b23 to 9a0ea2c Compare June 18, 2022 15:45
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.6.2 Update dependency squizlabs/php_codesniffer to v3.7.1 Jun 18, 2022
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from 9a0ea2c to 97b97bd Compare September 25, 2022 22:22
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from 97b97bd to 871723e Compare November 20, 2022 19:40
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.7.1 Update dependency squizlabs/php_codesniffer to v3.7.2 Mar 19, 2023
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from 871723e to c5791b7 Compare March 19, 2023 02:09
@renovate
Copy link
Contributor Author

renovate bot commented Jun 4, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: composer.lock
Command failed: composer update squizlabs/php_codesniffer:3.9.2 --with-dependencies --ignore-platform-req='ext-*' --ignore-platform-req='lib-*' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - phpspec/prophecy dev-master requires php ^7.2 || ~8.0, <8.2 -> your php version (8.3.6) does not satisfy that requirement.
    - phpunit/phpunit 9.5.10 requires phpspec/prophecy ^1.12.1 -> satisfiable by phpspec/prophecy[1.x-dev (alias of dev-master)].
    - phpspec/prophecy 1.x-dev is an alias of phpspec/prophecy dev-master and thus requires it to be installed too.
    - phpunit/phpunit is locked to version 9.5.10 and an update of this package was not requested.


@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from c5791b7 to c54f5a8 Compare June 4, 2023 00:44
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from c54f5a8 to bbfd4d6 Compare December 8, 2023 16:59
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.7.2 Update dependency squizlabs/php_codesniffer to v3.8.0 Dec 8, 2023
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from bbfd4d6 to dc90cdb Compare January 11, 2024 23:10
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.8.0 Update dependency squizlabs/php_codesniffer to v3.8.1 Jan 11, 2024
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from dc90cdb to 07cf15a Compare February 16, 2024 19:03
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.8.1 Update dependency squizlabs/php_codesniffer to v3.9.0 Feb 16, 2024
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from 07cf15a to ab28c81 Compare April 1, 2024 14:20
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.9.0 Update dependency squizlabs/php_codesniffer to v3.9.1 Apr 1, 2024
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from ab28c81 to ab971e7 Compare April 23, 2024 22:35
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.9.1 Update dependency squizlabs/php_codesniffer to v3.9.2 Apr 23, 2024
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from ab971e7 to be547ef Compare May 20, 2024 14:30
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.9.2 Update dependency squizlabs/php_codesniffer to v3.10.0 May 20, 2024
Copy link
Contributor Author

renovate bot commented May 20, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: composer.lock
Command failed: composer update squizlabs/php_codesniffer:3.10.3 --with-dependencies --ignore-platform-req='ext-*' --ignore-platform-req='lib-*' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - phpspec/prophecy dev-master requires php ^7.2 || ~8.0, <8.2 -> your php version (8.3.11) does not satisfy that requirement.
    - phpunit/phpunit 9.5.10 requires phpspec/prophecy ^1.12.1 -> satisfiable by phpspec/prophecy[1.x-dev (alias of dev-master)].
    - phpspec/prophecy 1.x-dev is an alias of phpspec/prophecy dev-master and thus requires it to be installed too.
    - phpunit/phpunit is locked to version 9.5.10 and an update of this package was not requested.


@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from be547ef to b9ed962 Compare May 22, 2024 22:41
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.10.0 Update dependency squizlabs/php_codesniffer to v3.10.1 May 22, 2024
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from b9ed962 to 2741c29 Compare July 22, 2024 01:25
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.10.1 Update dependency squizlabs/php_codesniffer to v3.10.2 Jul 22, 2024
@renovate renovate bot force-pushed the renovate/squizlabs-php_codesniffer-3.x branch from 2741c29 to 04a2002 Compare September 18, 2024 11:14
@renovate renovate bot changed the title Update dependency squizlabs/php_codesniffer to v3.10.2 Update dependency squizlabs/php_codesniffer to v3.10.3 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant