feat(stdlib): Implement ifSGNodeField.hasField() #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strattonbrazil
added
enhancement
sjbarag
reviewed
Jan 29, 2020
| returns: ValueKind.Boolean, | ||
| }, | ||
| impl: (interpreter: Interpreter, fieldname: BrsString) => { | ||
| return this.fields.has(fieldname.value.toLowerCase()) |
There was a problem hiding this comment.
For future reference, this could be as simple as:
Suggested change
| return this.fields.has(fieldname.value.toLowerCase()) | |
| return BrsBoolean.from( | |
| this.fields.has(fieldname.value.toLowerCase()) | |
| ) |
What you've got is of course fine though 😄
sjbarag
reviewed
Jan 29, 2020
|
|
||
| let hasField = node.getMethod("hasfield"); | ||
| let result1 = hasField.call(interpreter, new BrsString("foo")); | ||
| expect(result1).toEqual(new BrsBoolean(true)); |
There was a problem hiding this comment.
Also for future reference, this could be a tick simpler with expect(result1).toBe(BrsBoolean.True). Because there's only the two possible BrsBoolean values, they're exposed as static members of BrsBoolean for easy access!
sjbarag
reviewed
Jan 29, 2020
| @@ -35,6 +35,9 @@ sub main() | |||
| print "field1 in node now is: " node1.getField("field1") ' => hello | |||
| print "field3 in node now is: " node1.getField("field3") ' => false | |||
|
|
|||
| print "field3 present? " node1.hasField("field3") | |||
| print "fieldほ present? " node1.hasField("fieldほ") | |||
There was a problem hiding this comment.
Oh dang I've never thought about having non-ASCII characters in field names. I'm glad that works! 🎉
sjbarag
approved these changes
Jan 29, 2020
sjbarag
added
the
scenegraph
sjbarag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements hasField() (resolves #367 ). The implementation is simpler than the existing getField method, which returns a value, while this simply returns a boolean if the field is present.
There is at least one bug in hasField in the official implementation that I'm aware of, where calling hasField() with specific strings will actually create the field, but this is a bug and I don't think we should match that for compatibility sake.