Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix link to docs site #626

Merged
merged 1 commit into from
Mar 17, 2021
Merged

fix(docs): fix link to docs site #626

merged 1 commit into from
Mar 17, 2021

Conversation

lkipke
Copy link
Collaborator

@lkipke lkipke commented Mar 17, 2021

Summary

Whoops, in #625 I wrote a link backwards in markdown. This fixes it.

@lkipke lkipke added the bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior label Mar 17, 2021
@lkipke lkipke requested a review from sjbarag March 17, 2021 18:13
@lkipke lkipke self-assigned this Mar 17, 2021
alimnios72
alimnios72 reviewed Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@alimnios72 alimnios72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!ecin

sjbarag
sjbarag approved these changes Mar 17, 2021
View reviewed changes
Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that and assumed you just wanted the full URL to display inside the <a/> and didn't read any further 😅

@lkipke lkipke merged commit 32ce275 into sjbarag:main Mar 17, 2021
@lkipke lkipke deleted the fix-docs-site-link branch March 17, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimnios72 alimnios72 alimnios72 left review comments

@sjbarag sjbarag sjbarag approved these changes

Assignees

@lkipke lkipke

Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkipke @sjbarag @alimnios72