Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): reset mocks between executions #649

Merged
merged 1 commit into from
May 6, 2021

Conversation

lkipke
Copy link
Collaborator

@lkipke lkipke commented Apr 23, 2021

Change summary

This resets mocks between executions that share the same base scope, to prevent them from polluting/interfering with each other. Got the idea from the implementation in #646!

Related: hulu/roca#89

@lkipke lkipke added the bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior label Apr 23, 2021
@lkipke lkipke self-assigned this Apr 23, 2021
Copy link
Collaborator

@alimnios72 alimnios72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here!

@lkipke lkipke merged commit 783e509 into sjbarag:main May 6, 2021
@lkipke lkipke deleted the reset-mocks branch May 6, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants