Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rsg): Add boundingrect function to node #665

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

underwoo16
Copy link
Contributor

Implemented boundingRect function for roSGNode with zero-defaulted values

https://developer.roku.com/docs/references/brightscript/interfaces/ifsgnodeboundingrect.md

Copy link
Collaborator

@lkipke lkipke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, given that we have several other components with skeleton implementations. Can you also open a PR into roca to update the docs? Probably this one specifically: implementation-gaps.md

@underwoo16
Copy link
Contributor Author

I'm fine with this, given that we have several other components with skeleton implementations. Can you also open a PR into roca to update the docs? Probably this one specifically: implementation-gaps.md

I think the comment that it is mostly complete is still accurate since I only implemented one out of ~7 methods from this interface. I have never seen the other methods used so I only implemented boundingrect.

Would you prefer I implement all of the methods or file an issue to complete the missing methods?

@sjbarag
Copy link
Owner

sjbarag commented Sep 20, 2021

I'm fine with this, given that we have several other components with skeleton implementations. Can you also open a PR into roca to update the docs? Probably this one specifically: implementation-gaps.md

I think the comment that it is mostly complete is still accurate since I only implemented one out of ~7 methods from this interface. I have never seen the other methods used so I only implemented boundingrect.

Would you prefer I implement all of the methods or file an issue to complete the missing methods?

You're fine as-is for now 🤷 It's still mostly-complete, and we're getting closer slowly

@sjbarag sjbarag changed the title [NO-ISSUE] - Added boundingrect function to node feat(rsg): Added boundingrect function to node Sep 20, 2021
@sjbarag sjbarag changed the title feat(rsg): Added boundingrect function to node feat(rsg): Add boundingrect function to node Sep 20, 2021
@sjbarag sjbarag merged commit 8915cd4 into sjbarag:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants