Several changes #23
Open
Several changes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function of the main file with an old undo.
…n-errors-nonetype-not-iterable-with Looks like its possible to get a NoneType in a list?
Updated vim docs.
Minor fix to get the merge working (indenting): Conflicts: autoload/gundo.py
|
I'm probably not gonna take all of these but I'll at least take a few when I get some time to go through them. |
|
Maybe there would be better luck if these were individual pull requests. Smaller chunks means easier to digest and merge. |
|
👍 |
|
@sukima I did in the original bitbucket site where these fixes came from...back when I made these fixes (several years ago now). After I didn't get a response after about a month, I just made my own fork. I see @simnalamburt you're making your own fork? Perhaps we could join forces. My branch (https://github.com/dsummersl/gundo.vim) isn't significantly different from the original work here, however it does add some nice features:
|
|
@dsummersl I was planned to do so simnalamburt/vim-mundo#3 Let's do this |
dsummersl
pushed a commit
to dsummersl/gundo.vim
that referenced
this pull request
Nov 27, 2016
Convert version numbers to strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added several fixes/additions. Here's a complete list:
Haven't heard anything from the first pull request - maybe I'd do better over on the bitbucket site...I'll cross post there...