[Incomplete] Support for docstring rules #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akeemphilbert
added a commit
to akeemphilbert/stucumber
that referenced
this pull request
Apr 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya, I thought I'd be able to make you a nice ready-to-go PR for this, but alas, I won't be able to work on this further.
This adds parser support for the docstring syntax supported by the official parser - described here:
https://cucumber.io/docs/reference#doc-strings
I believe the parser addition is sound (tests included) but I didn't have a chance to figure out how to properly forward it to the step definition handler. It should just be the last arg of the callback, same as table (but without being wrapped in anything - the raw string without indents will suffice IMO).
As-is it's available on the parsed Rule object under the key
docstring(instead oftable, basically).Hope you find this useful!