Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin doesn't handle skaled error #1081

Closed
yatsunastya opened this issue Jun 18, 2024 · 2 comments · Fixed by #1086
Closed

Admin doesn't handle skaled error #1081

yatsunastya opened this issue Jun 18, 2024 · 2 comments · Fixed by #1086
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yatsunastya
Copy link

Describe the bug
There is a problem in skaled skalenetwork/skaled#1922.
Admin doesn't handle this issue:

[2024-06-14 11:53:48,570 INFO][18489][sparse-gross-lesath][T_1] - core.schains.firewall.utils:42 - Creating rule controller for sparse-gross-lesath
[2024-06-14 11:53:48,577 ERROR][18489][sparse-gross-lesath][T_1] - core.schains.task:26 - Task sparse-gross-lesath-skaled failed with 'result'
Traceback (most recent call last):
  File "/usr/src/admin/core/schains/task.py", line 24, in run
    self.action()
  File "/usr/src/admin/core/schains/monitor/main.py", line 162, in run_skaled_pipeline
    status = skaled_checks.get_all(log=False, expose=True)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/admin/core/schains/checks.py", line 126, in get_all
    if hasattr(self, name):
       ^^^^^^^^^^^^^^^^^^^
  File "/usr/src/admin/core/schains/checks.py", line 402, in blocks
    return CheckRes(check_endpoint_blocks(http_endpoint))
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/admin/core/schains/rpc.py", line 52, in check_endpoint_blocks
    latest_schain_timestamp_hex = res_data['result']['timestamp']
                                  ~~~~~~~~^^^^^^^^^^
KeyError: 'result'
[2024-06-14 11:53:48,578 INFO][18489][sparse-gross-lesath][T_1] - core.schains.task:27 - Sleeping after task execution for 2

As a result it prevents starting skaled monitor.

Versions:
Admin: 2.7.0-beta.1
Skaled: 3.19.0-beta.1

To Reproduce
Steps to reproduce the behavior:

  1. Run schain creation/ node rotation
  2. Check admin logs

Expected behavior
Admin restarts schain container.

@yatsunastya yatsunastya added the bug Something isn't working label Jun 18, 2024
@badrogger
Copy link
Contributor

From my point of view it should be fixed in 2.4

@PolinaKiporenko PolinaKiporenko added this to the SKALE 2.4 milestone Jun 19, 2024
@badrogger badrogger linked a pull request Jul 5, 2024 that will close this issue
@yatsunastya
Copy link
Author

As the skaled issue was fixed, it's not possible to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants