Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle json parsing errors in rpc check #1086

Merged
merged 10 commits into from
Jul 9, 2024
Merged

Handle json parsing errors in rpc check #1086

merged 10 commits into from
Jul 9, 2024

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Jul 2, 2024

Changes:

  • Improved error handling of failed helathcheck rpc request to skaled.

Testing

  • Added new unit tests.
  • Retested basic functions on the internal network.

Perfomance

  • No perfomance related changes were introduced.

@badrogger badrogger linked an issue Jul 5, 2024 that may be closed by this pull request
@badrogger badrogger marked this pull request as ready for review July 9, 2024 09:57
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (aa85bd9) to head (e547f09).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1086      +/-   ##
===========================================
+ Coverage    81.52%   81.55%   +0.02%     
===========================================
  Files          103      103              
  Lines         6041     6049       +8     
===========================================
+ Hits          4925     4933       +8     
  Misses        1116     1116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmytrotkk dmytrotkk merged commit e80597c into develop Jul 9, 2024
6 checks passed
@dmytrotkk dmytrotkk deleted the fix-rpc-check branch July 9, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin doesn't handle skaled error
2 participants