Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/add historic custom builds #1925

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Enhancement/add historic custom builds #1925

merged 8 commits into from
Jun 14, 2024

Conversation

DmytroNazarenko
Copy link
Collaborator

@DmytroNazarenko DmytroNazarenko commented Jun 13, 2024 •
edited
Loading

Description

Make custom build workflow to build and publish both historic and core skaled to docker hub

Tests

Run new custom build workflow on github

Performance Impact

No impact

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@DmytroNazarenko DmytroNazarenko linked an issue Jun 13, 2024 that may be closed by this pull request
Add options for custom builds #1910
Closed
olehnikolaiev
olehnikolaiev previously approved these changes Jun 13, 2024
View reviewed changes
dimalit
dimalit previously approved these changes Jun 13, 2024
View reviewed changes
@olehnikolaiev olehnikolaiev self-requested a review June 14, 2024 12:28
@DmytroNazarenko DmytroNazarenko merged commit a0d0c55 into develop Jun 14, 2024
7 checks passed
@DmytroNazarenko DmytroNazarenko deleted the enhancement/add-historic-custom-builds branch June 14, 2024 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dimalit dimalit dimalit approved these changes

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options for custom builds
3 participants
@DmytroNazarenko @dimalit @olehnikolaiev