Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKALED-1935 Fix skale-vm and test.ClientBase build #1968

Merged
merged 3 commits into from
Sep 13, 2024
Merged

SKALED-1935 Fix skale-vm and test.ClientBase build #1968

merged 3 commits into from
Sep 13, 2024

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Aug 22, 2024 •
edited
Loading

Adapted full build to use new patch timestamp architecture.
Fixed make test.ClientBase (we are not using it, but now it runs).

skale-vm now compiles, does not crash, but still doesn't work fully correctly (as before), see #1972

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@dimalit dimalit linked an issue Aug 22, 2024 that may be closed by this pull request
Skaled full build broken #1935
Open
@dimalit dimalit changed the title SKALED-1935 Fix skale-vm build SKALED-1935 Fix skale-vm and test.ClientBase build Aug 28, 2024
@dimalit dimalit marked this pull request as ready for review August 28, 2024 12:52
@dimalit dimalit removed a link to an issue Aug 28, 2024
Skaled full build broken #1935
Open
@dimalit dimalit linked an issue Aug 28, 2024 that may be closed by this pull request
Skaled full build broken #1935
Open
@dimalit dimalit merged commit c2dd5c6 into v3.20.0 Sep 13, 2024
6 of 7 checks passed
@dimalit dimalit deleted the enhancement/SKALED-1935-full-build branch September 13, 2024 10:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kladkogex kladkogex kladkogex approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaled full build broken
3 participants
@dimalit @kladkogex @DmytroNazarenko