Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling state root check for sync/indexer/archive nodes #2022

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

DmytroNazarenko
Copy link
Collaborator

@DmytroNazarenko DmytroNazarenko commented Oct 11, 2024

Description

This PR enables state root check for sync, indexer and archive nodes. If a state root discrepancy is detected, the node will stop and exit with code 200.

Tests

Tested on the devnet:

  1. Create Schain with indexer node
  2. Wait for 3 snapshots
  3. Modify /var/lib/skale/schains/[CHAIN_NAME]/snapshots/[CURRENT_SNAPSHOT_BN]/snapshot_hash.txt
  4. Check that indexer node container stopped with exit code 200 and data dir is intact

Same procedure for the archive node

Performance Impact

No performance impact

@DmytroNazarenko DmytroNazarenko marked this pull request as draft October 11, 2024 11:29
Base automatically changed from v3.20.0 to 1545_state_locking_final October 11, 2024 11:40
@DmytroNazarenko DmytroNazarenko changed the base branch from 1545_state_locking_final to v3.20.0 October 11, 2024 11:46
@DmytroNazarenko DmytroNazarenko marked this pull request as ready for review October 11, 2024 19:18
@olehnikolaiev olehnikolaiev self-requested a review October 14, 2024 10:49
@DmytroNazarenko DmytroNazarenko merged commit 9b436bc into v3.20.0 Oct 14, 2024
9 of 10 checks passed
@DmytroNazarenko DmytroNazarenko deleted the enhancement/enable-state-root-check branch October 14, 2024 11:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants