RRULE: Fix floating UNTIL with dateutil > 2.6.1 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dateutil raises an exception when UNTIL is UTC and ``dtstart`` is not set. This restores the old behaviour, because ``isinstance(dtstart, datetime.date)`` is always true.
|
I now realize that the original behaviour is wrong. |
This reverts commit 8e28129. The original behaviour was wrong. ``ignoretz=isinstance(dtstart, datetime.date)`` is always True, this causes vobject to always drop the time zone from UNTIL. If DTSTART has a time zone and UNTIL is UTC, the time zone of UNTIL gets replaced by the time zone of DTSTART without adjustment.
Closed
|
@Unrud this looks good, but can you write a test for this behavior (ie floating UNTIL and DTSTART with defined timezone)? |
9 tasks
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113, #112
dateutil > 2.6.1 raises an exception when UNTIL is floating and DTSTART is not. This PR fixes the issue by parsing the RRULE first without DTSTART to extract the UNTIL parameter and then without the UNTIL parameter but with DTSTART. The RRULE without UNTIL and the normalized UNTIL are combined at the end.
This PR makes #111 obsolete.