replace str.decode / str.encode for base64 and quoted-printable. should fix #20 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prauscher I had to add bytes() before base64 decoding, see arska@fd07a9f |
|
@arska thank you, but line.value.encode("utf-8") works in python2 too |
|
+1 |
This was referenced Aug 26, 2016
| @@ -147,7 +149,7 @@ def encode(cls, line): | |||
| if not line.encoded: | |||
| encoding = getattr(line, 'encoding_param', None) | |||
| if encoding and encoding.upper() == cls.base64string: | |||
| line.value = line.value.encode('base64').replace('\n', '') | |||
| line.value = codecs.encode(line.value.encode(coding), "base64").decode("utf-8") | |||
There was a problem hiding this comment.
The variable 'coding' is not defined? Is this a typo?
It looks like when my vcard has a photo which is base64 encoded, this breaks vcard.serialize().
I'm attaching a sample vcard test_file. The vcard has photo data encoded in base64 format.
On python 2.7, a simple vcard.readOne(...).serialize() will fail.
sample_vcard.txt
There was a problem hiding this comment.
Perhaps my pull request on top will fix this: #49
lucc
pushed a commit
to lucc/vobject
that referenced
this pull request
Apr 9, 2024
Fix bad backslash escape usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as said. assumed internal encoding of utf-8, but actually i'm not entirely sure if this is how you handle things. therefore please tell me what to change and i'll do extra commits