-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/improve progress radial #2093
Feat/improve progress radial #2093
Conversation
🦋 Changeset detectedLatest commit: 638b7c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@edrichhans very cool - I'll do a proper review next week, but at a glance this looks like something we'll move forward with. Thanks! |
@edrichhans, as expected this is a very cool change! I really dig this, and the simplicity is wonderful. I went ahead and made a few changes as part of my review:
The general idea is we want props to be a pass through for any and all options when we can. Though I understand why you didn't opt for including Thank you for this contribution, this will be merged and be a part of next week's new release! |
Happy to contribute @endigo9740 , thanks for approving and merging |
Linked Issue
Closes #2092
Description
Introduces a new prop
roundedLineCap
that allows customization of the progress radial. Renaming the prop is welcome.Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages/skeleton
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
. - Done ✅Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm check
pnpm format
pnpm test