Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve progress radial #2093

Merged
merged 10 commits into from
Oct 6, 2023

Conversation

edrichhans
Copy link
Contributor

@edrichhans edrichhans commented Oct 1, 2023

Linked Issue

Closes #2092

Description

Introduces a new prop roundedLineCap that allows customization of the progress radial. Renaming the prop is welcome.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:. - Done ✅

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2023

🦋 Changeset detected

Latest commit: 638b7c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Oct 6, 2023 5:05pm

@endigo9740
Copy link
Contributor

@edrichhans very cool - I'll do a proper review next week, but at a glance this looks like something we'll move forward with. Thanks!

@endigo9740
Copy link
Contributor

@edrichhans, as expected this is a very cool change! I really dig this, and the simplicity is wonderful.

I went ahead and made a few changes as part of my review:

  1. Make sure to only target /package projects when generating changesets, never /sites (we don't log changes for the doc site yet)
  2. I've renamed the prop name to strokeLinecap to be closer to the attribute
  3. I've replaced the boolean with a union type, which allows for all three possible options for 'butt' | 'round' | 'square'
  4. I've kept butt as the default value though
  5. Updated the documentation to match these changes

The general idea is we want props to be a pass through for any and all options when we can. Though I understand why you didn't opt for including square - it's a bit odd!

Thank you for this contribution, this will be merged and be a part of next week's new release!

@endigo9740 endigo9740 merged commit 7286219 into skeletonlabs:dev Oct 6, 2023
3 of 4 checks passed
@edrichhans
Copy link
Contributor Author

Happy to contribute @endigo9740 , thanks for approving and merging

@edrichhans edrichhans deleted the feat/improve-progress-radial branch April 3, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow rounding of Progress Radial meter edges
2 participants